[I] Varaint Type: Add logical type annotation for writer [iceberg-rust]

["c-thiel (via GitHub)" <gi...@apache.org>]

c-thiel opened a new issue, #2546:
URL: https://github.com/apache/iceberg-rust/issues/2546

   ### Is your feature request related to a problem or challenge?
   
   Follow up to https://github.com/apache/iceberg-rust/pull/2188#discussion_r 
   
   iceberg-rust writes via `AsyncArrowWriter`, which derives the Parquet schema from the Arrow schema. In parquet 58.1.0, that path only emits the VARIANT annotation when the field carries the `parquet_variant_compute::VariantType` extension type and variant_experimental is enabled (otherwise logical_type_for_struct is a stub returning None). I couldn't find a public per-field hook to inject the annotation onto a plain `Struct(Binary,Binary)`.
   
   So the real cost is: enable `variant_experimental` + attach the extension type to the field. Two risks that I see:
   1. Turning on the feature may change how the reader decodes a VARIANT-annotated group (native VariantArray instead of Struct{metadata,value}) — could break the current read path that expects the struct.
   2. New experimental dep surface.
   
   Surfaced here: https://github.com/apache/iceberg-rust/pull/2188#discussion_r3326706646
   
   ### Describe the solution you'd like
   
   _No response_
   
   ### Willingness to contribute
   
   None


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [I] Varaint Type: Add logical type annotation for writer [iceberg-rust]

["dannycjones (via GitHub)" <gi...@apache.org>]

dannycjones commented on issue #2546:
URL: https://github.com/apache/iceberg-rust/issues/2546#issuecomment-4981797459

   I noticed that we're not providing any logical type annotations when writing Parquet files.
   
   Does this issue propose that we address that uniformly, ensuring each type has a logical type annotation (where applicable)? I'm trying to understand the current state and where we want to be.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org