You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iotdb.apache.org by ej...@apache.org on 2020/05/21 07:16:21 UTC

[incubator-iotdb] 01/02: add some TODO

This is an automated email from the ASF dual-hosted git repository.

ejttianyu pushed a commit to branch dev_new_merge
in repository https://gitbox.apache.org/repos/asf/incubator-iotdb.git

commit 6605e900154d3a1e7966fc7c622fcf66be9f23e2
Author: EJTTianyu <16...@qq.com>
AuthorDate: Thu Apr 23 15:39:57 2020 +0800

    add some TODO
---
 .../engine/merge/seqMerge/inplace/selector/InplaceMaxFileSelector.java  | 2 +-
 .../org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java  | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/server/src/main/java/org/apache/iotdb/db/engine/merge/seqMerge/inplace/selector/InplaceMaxFileSelector.java b/server/src/main/java/org/apache/iotdb/db/engine/merge/seqMerge/inplace/selector/InplaceMaxFileSelector.java
index 45e9a4b..cd2bb10 100644
--- a/server/src/main/java/org/apache/iotdb/db/engine/merge/seqMerge/inplace/selector/InplaceMaxFileSelector.java
+++ b/server/src/main/java/org/apache/iotdb/db/engine/merge/seqMerge/inplace/selector/InplaceMaxFileSelector.java
@@ -100,7 +100,7 @@ public class InplaceMaxFileSelector extends BaseFileSelector {
         this.selectorContext.updateTimeConsumption();
         continue;
       }
-
+      //TODO: what is this cost used for?
       tempMaxSeqFileCost = maxSeqFileCost;
       long newCost = useTightBound ? this.memCalculator
           .calculateTightMemoryCost(unseqFile, tmpSelectedSeqFiles, this.seqFiles,
diff --git a/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java b/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
index 9f8919c..43353ef 100755
--- a/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
+++ b/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
@@ -1343,6 +1343,7 @@ public class StorageGroupProcessor {
       try {
         Pair<MergeResource, SelectorContext> selectRes = fileSelector.selectMergedFiles();
         MergeResource mergeResource = selectRes.left;
+        //TODO: what is this attr used for?
         SelectorContext selectorContext = selectRes.right;
         if (mergeResource.getSeqFiles().size() == 0 && mergeResource.getUnseqFiles().size() == 0) {
           logger.info("{} cannot select merge candidates under the budget {}", storageGroupName,