[jira] [Commented] (FLINK-7324) Remove Flink's futures from SlotPool

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108788#comment-16108788 ] 

ASF GitHub Bot commented on FLINK-7324:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4438#discussion_r130589358
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java ---
    @@ -344,4 +344,26 @@ public void onComplete(Throwable failure, T success) throws Throwable {
     
     		return result;
     	}
    +
    +	/**
    +	 * Converts a Java 8 {@link java.util.concurrent.CompletableFuture} into a Flink {@link Future}.
    +	 *
    +	 * @param javaFuture to convert to a Flink future
    +	 * @param <T> type of the future value
    +	 * @return Flink future
    +	 */
    +	public static <T> Future<T> toFlinkFuture(java.util.concurrent.CompletableFuture<T> javaFuture) {
    --- End diff --
    
    Good point. Will add it.


> Remove Flink's futures from SlotPool
> ------------------------------------
>
>                 Key: FLINK-7324
>                 URL: https://issues.apache.org/jira/browse/FLINK-7324
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.4.0
>
>
> This only refers to the internal usage of Flink's {{Future}} usage in {{SlotPool}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)