You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/02 16:22:03 UTC
[GitHub] [pulsar] gaoran10 opened a new pull request #7435: Shaded jclouds to avoid gson conflict
gaoran10 opened a new pull request #7435:
URL: https://github.com/apache/pulsar/pull/7435
Fixes #7402
### Motivation
Currently, the GCS offload error is still existing. In jclouds `2.2.0` and `2.2.1`, it only shaded the package [`com.google.gson.internal`](https://github.com/apache/jclouds/blob/master/gson/gson-shaded/pom.xml#L70), and in the class [`org.jclouds.json.internal.NullFilteringTypeAdapterFactories`](https://github.com/apache/jclouds/blob/master/core/src/main/java/org/jclouds/json/internal/NullFilteringTypeAdapterFactories.java#L319) the shaded class `org.jclouds.json.gson.internal.JsonReaderInternalAccess` will be initialized by `com.google.gson.stream.JsonReader` which is in jclouds, the Pulsar include the same class `com.google.gson.stream.JsonReader` and when Pulsar broker start it will be loaded before jclouds's, so this will cause the `org.jclouds.json.gson.internal.JsonReaderInternalAccess` can't be initialized successfully, and occurs NPE.
### Modifications
Shaded the jclouds to make the class `org.jclouds.json.gson.internal.JsonReaderInternalAccess` could be initialized normally.
### Verifying this change
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai merged pull request #7435: [Issue 7402] Shaded jclouds to avoid gson conflict
Posted by GitBox <gi...@apache.org>.
jiazhai merged pull request #7435:
URL: https://github.com/apache/pulsar/pull/7435
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #7435: [Issue 7402] Shaded jclouds to avoid gson conflict
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #7435:
URL: https://github.com/apache/pulsar/pull/7435#issuecomment-653864242
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #7435: [Issue 7402] Shaded jclouds to avoid gson conflict
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #7435:
URL: https://github.com/apache/pulsar/pull/7435#issuecomment-653106630
@merlimat Please reopen #7402, the #7400 only test successfully in the project `org.apache.pulsar:tiered-storage-jcloud`, the problem is still existing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 edited a comment on pull request #7435: [Issue 7402] Shaded jclouds to avoid gson conflict
Posted by GitBox <gi...@apache.org>.
gaoran10 edited a comment on pull request #7435:
URL: https://github.com/apache/pulsar/pull/7435#issuecomment-653106630
Please reopen #7402, the #7400 only test successfully in the project `org.apache.pulsar:tiered-storage-jcloud`, the problem is still existing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org