[jira] [Commented] (OFBIZ-11721) Enforce noninstantiability to BillingAccountWorker Class

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-11721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125722#comment-17125722 ] 

ASF subversion and git services commented on OFBIZ-11721:
---------------------------------------------------------

Commit 9ade9d776b41cbe33731ec4702d6c1d5dd3ff990 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9ade9d7 ]

Improved: Enforce noninstantiability to BillingAccountWorker Class. (#167)

(OFBIZ-11721)
Made class as final, added private constructor, changed data members to private and corrected names as per naming convention.

> Enforce noninstantiability to BillingAccountWorker Class
> --------------------------------------------------------
>
>                 Key: OFBIZ-11721
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11721
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>    Affects Versions: Upcoming Branch
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>
> - Make BillingAccountWorker class as final.
>  - Add a private constructor.
>  - Make the following variable as private
> {code:java}
> public static final String MODULE = BillingAccountWorker.class.getName();
> public static final String resourceError = "AccountingUiLabels";
> public static final int decimals = UtilNumber.getBigDecimalScale("order.decimals");
> public static final RoundingMode rounding = UtilNumber.getRoundingMode("order.rounding");
> public static final BigDecimal ZERO = BigDecimal.ZERO.setScale(decimals, rounding);
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)