[jira] Commented: (HARMONY-4622) [drlvm][jit][opt] Dublicated functionality in Loop.cpp and loop_unrolling.cpp

["Egor Pasko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HARMONY-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519391 ] 

Egor Pasko commented on HARMONY-4622:
-------------------------------------

actually, Loop.cpp not only does unrolling, but also some peeling and loop invariants initialization. It is rather messy in some ways, for example, ABCD does not work very well with this stuff (dunno why yet). But, it could be a significant performance degradation if we remove the "peel" completely.

A want just to make sure that you are proposing to remove only unrolling and leave other peel stuff as is for now..

> [drlvm][jit][opt] Dublicated functionality in Loop.cpp and loop_unrolling.cpp
> -----------------------------------------------------------------------------
>
>                 Key: HARMONY-4622
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4622
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: vasily.v.levchenko@gmail.com
>            Priority: Trivial
>
> Hi folks,
> I've found some duplication code in Jitrino for loop unroll optimization:
> loop.unroll, loop.unroll_count in Loop.cpp and reacher set of parameter in loop_unroll.cpp.
>  The unroll optimization in Loop.cpp seems to be good candidate to be removed. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.