[GitHub] [doris] adonis0147 commented on a diff in pull request #10278: [Improvement] remove olap filters when use in key ranges

[GitBox <gi...@apache.org>]

adonis0147 commented on code in PR #10278:
URL: https://github.com/apache/doris/pull/10278#discussion_r902279461


##########
be/src/exec/olap_common.h:
##########
@@ -856,4 +859,125 @@ Status OlapScanKeys::extend_scan_key(ColumnValueRange<T>& range, int32_t max_sca
     return Status::OK();
 }
 
+template <class T>
+Status OlapScanKeys::extend_scan_key(ColumnValueRange<T>& range, int32_t max_scan_key_num,
+                                     bool* exact_value) {
+    using namespace std;
+    typedef typename set<T>::const_iterator const_iterator_type;

Review Comment:
   1. Use camel case for type.
   2. Prefer `using` to `typedef`
   
   ```suggestion
       using ConstIterator = typename set<T>::const_iterator;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org