You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by gi...@git.apache.org on 2017/06/20 16:38:51 UTC
[GitHub] jpkrohling opened a new pull request #2403: [wip] Draft 1 - Wrap runs within OpenTracing spans
jpkrohling opened a new pull request #2403: [wip] Draft 1 - Wrap runs within OpenTracing spans
URL: https://github.com/apache/incubator-openwhisk/pull/2403
This is just a first draft, intended to start a discussion on the OpenTracing integration. This includes also a concrete OpenTracing tracer implementation (Jaeger) but the code itself is only using OpenTracing APIs.
Things to discuss:
- [ ] How to use other Trace implementations. I'm not sure how the classpath works for Scala applications, but from the OpenTracing's perspective, it will get whatever implementation is on the classpath (ideally, there would be exactly one)
- [ ] Location of the span -- I added the OpenTracing code on the `run()` method on the invoker, but I'm not 100% familiar with OpenWhisk yet. Is this the right place?
This is how it looks like in Jaeger with this PR:
List of traces (only one span per trace for now):
Span details:
If this PR is merged, I'll work on context propagation, so that a trace would have more spans (example: if `hello` invokes `aloha`, both are shown in the same trace)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services