[GitHub] [lucene-solr] murblanc commented on a change in pull request #1980: SOLR-14930: Deprecate rulebased replica placement strategy

[GitBox <gi...@apache.org>]

murblanc commented on a change in pull request #1980:
URL: https://github.com/apache/lucene-solr/pull/1980#discussion_r504718678



##########
File path: solr/core/src/java/org/apache/solr/cloud/api/collections/Assign.java
##########
@@ -556,19 +500,8 @@ public static AssignStrategy createAssignStrategy(SolrCloudManager solrCloudMana
       // If a cluster wide placement plugin is configured (and that's the only way to define a placement plugin), it overrides
       // per collection configuration (i.e. rules are ignored)

Review comment:
       Need to update comment as with rules gone, there's nothing per collection anymore




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org