You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/10 13:20:20 UTC
[GitHub] [spark] yucai commented on a change in pull request #24004:
[SPARK-27084][SQL] Add function alias for bitand/bitnot/bitor/bitxor
yucai commented on a change in pull request #24004: [SPARK-27084][SQL] Add function alias for bitand/bitnot/bitor/bitxor
URL: https://github.com/apache/spark/pull/24004#discussion_r264038353
##########
File path: sql/core/src/test/resources/sql-tests/inputs/bitwise.sql
##########
@@ -0,0 +1,15 @@
+--test case for bitnot function
+SELECT ~1, ~1000, ~1000000, ~123456789123;
Review comment:
'-- test case' looks better? And same on the others below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org