You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by pa...@apache.org on 2022/06/16 09:05:32 UTC
[shardingsphere] branch master updated: Refactor MetaDataRefreshEngineTest (#18390)
This is an automated email from the ASF dual-hosted git repository.
panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new bee3dd221d0 Refactor MetaDataRefreshEngineTest (#18390)
bee3dd221d0 is described below
commit bee3dd221d01cea8a2d5a4bfa2e6cb4f8b59ab17
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Thu Jun 16 17:05:23 2022 +0800
Refactor MetaDataRefreshEngineTest (#18390)
---
.../infra/context/refresher/MetaDataRefreshEngineTest.java | 6 ++++--
.../context/refresher/type/DummyDropDatabaseMetaDataRefresher.java | 3 ---
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/shardingsphere-infra/shardingsphere-infra-context/src/test/java/org/apache/shardingsphere/infra/context/refresher/MetaDataRefreshEngineTest.java b/shardingsphere-infra/shardingsphere-infra-context/src/test/java/org/apache/shardingsphere/infra/context/refresher/MetaDataRefreshEngineTest.java
index 15119e5daae..fa19903d80c 100644
--- a/shardingsphere-infra/shardingsphere-infra-context/src/test/java/org/apache/shardingsphere/infra/context/refresher/MetaDataRefreshEngineTest.java
+++ b/shardingsphere-infra/shardingsphere-infra-context/src/test/java/org/apache/shardingsphere/infra/context/refresher/MetaDataRefreshEngineTest.java
@@ -50,7 +50,6 @@ public final class MetaDataRefreshEngineTest {
@Test
public void assertRefreshNonIgnorableSQLStatement() throws Exception {
- final int dropTimes = 10;
SQLStatementContext<DropDatabaseStatement> sqlStatementContext = mock(SQLStatementContext.class);
when(sqlStatementContext.getSqlStatement()).thenReturn(mock(DropDatabaseStatement.class));
when(sqlStatementContext.getTablesContext()).thenReturn(mock(TablesContext.class));
@@ -60,12 +59,14 @@ public final class MetaDataRefreshEngineTest {
Field field = metaDataRefreshEngine.getClass().getDeclaredField("database");
field.setAccessible(true);
field.set(metaDataRefreshEngine, database);
+ int dropTimes = 10;
for (int i = 0; i < dropTimes; i++) {
metaDataRefreshEngine.refresh(sqlStatementContext, Collections::emptyList);
}
verify(sqlStatementContext.getSqlStatement(), times(dropTimes)).getDatabaseName();
}
+ @SuppressWarnings("unchecked")
@Test
public void assertRefreshIgnorableSQLStatement() throws SQLException {
SQLStatementContext<SelectStatement> sqlStatementContext = mock(SQLStatementContext.class);
@@ -74,7 +75,8 @@ public final class MetaDataRefreshEngineTest {
assertTrue(getIgnorableSQLStatementClasses().contains(sqlStatementContext.getSqlStatement().getClass()));
}
- @SneakyThrows
+ @SuppressWarnings("unchecked")
+ @SneakyThrows(ReflectiveOperationException.class)
private Set<Class<? extends SQLStatement>> getIgnorableSQLStatementClasses() {
Field field = MetaDataRefreshEngine.class.getDeclaredField("IGNORABLE_SQL_STATEMENT_CLASSES");
field.setAccessible(true);
diff --git a/shardingsphere-infra/shardingsphere-infra-context/src/test/java/org/apache/shardingsphere/infra/context/refresher/type/DummyDropDatabaseMetaDataRefresher.java b/shardingsphere-infra/shardingsphere-infra-context/src/test/java/org/apache/shardingsphere/infra/context/refresher/type/DummyDropDatabaseMetaDataRefresher.java
index 4358371ecc7..14e8e236397 100644
--- a/shardingsphere-infra/shardingsphere-infra-context/src/test/java/org/apache/shardingsphere/infra/context/refresher/type/DummyDropDatabaseMetaDataRefresher.java
+++ b/shardingsphere-infra/shardingsphere-infra-context/src/test/java/org/apache/shardingsphere/infra/context/refresher/type/DummyDropDatabaseMetaDataRefresher.java
@@ -29,9 +29,6 @@ import java.util.Collection;
import java.util.Map;
import java.util.Optional;
-/**
- * MetaDataRefresher for testing.
- */
public final class DummyDropDatabaseMetaDataRefresher implements MetaDataRefresher<DropDatabaseStatement> {
@Override