[GitHub] [guacamole-server] myjimmy commented on a change in pull request #312: GUACAMOLE-1201: Fix audio input issue on mme

[GitBox <gi...@apache.org>]

myjimmy commented on a change in pull request #312:
URL: https://github.com/apache/guacamole-server/pull/312#discussion_r532719536



##########
File path: src/protocols/rdp/channels/audio-input/audio-buffer.h
##########
@@ -273,5 +317,22 @@ void guac_rdp_audio_buffer_end(guac_rdp_audio_buffer* audio_buffer);
  */
 void guac_rdp_audio_buffer_free(guac_rdp_audio_buffer* audio_buffer);
 
+/**
+ * This thread handler sends the audio input stream data to the remote server
+ * in the uniform interval.
+ * When sending it via the MME interface of the remote server as soon as
+ * receiving the audio input stream from the client, the missing some audio stream
+ * occurs due to the lack of remote audio buffer.
+ * So, to prevent the remote audio buffer from running out of space seems,
+ * we need to use the thread to send the audio stream in the uniform interval.
+ *
+ * @param data
+ *     The pointer to the guac_rdp_audio_buffer object maintained by RDP session.
+ *
+ * @return
+ *     NULL. This is a normal format of the general thread callback functions.

Review comment:
       When defining the thread callback function and using it, the function generally returns a NULL pointer.
   I documented this as the above comment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org