You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/14 04:37:14 UTC
[GitHub] [pulsar] mostafij-rahman opened a new pull request #12030: Issue 12019 Fix flaky test ManagedLedgerTest.testMaximumRolloverTime
mostafij-rahman opened a new pull request #12030:
URL: https://github.com/apache/pulsar/pull/12030
Fixes #12019
### Motivation
Fix flaky test ManagedLedgerTest.testMaximumRolloverTime
This test was failing sporadically due to using Thread.sleep(2000). However, due to using a constant time of 2000 milliseconds, it sometimes added more entry than expected.
### Modifications
- Remove Thread.sleep(2000)
- Put the assertion into Awaitility.await()
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [x] no-need-doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #12030: Issue 12019 Fix flaky test ManagedLedgerTest.testMaximumRolloverTime
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #12030:
URL: https://github.com/apache/pulsar/pull/12030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #12030: Issue 12019 Fix flaky test ManagedLedgerTest.testMaximumRolloverTime
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #12030:
URL: https://github.com/apache/pulsar/pull/12030#issuecomment-956031434
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #12030: Issue 12019 Fix flaky test ManagedLedgerTest.testMaximumRolloverTime
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #12030:
URL: https://github.com/apache/pulsar/pull/12030#discussion_r708073650
##########
File path: managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java
##########
@@ -1755,8 +1755,8 @@ public void testMinimumRolloverTime() throws Exception {
ledger.addEntry("data".getBytes());
ledger.addEntry("data".getBytes());
-
- assertEquals(ledger.getLedgersInfoAsList().size(), 2);
+
+ assertEquals(ledger.getLedgersInfoAsList().size(), 2);
Review comment:
please remove trailing spaces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org