[GitHub] [ignite] vladErmakov07 opened a new pull request #9630: IGNITE-16062

[GitBox <gi...@apache.org>]

vladErmakov07 opened a new pull request #9630:
URL: https://github.com/apache/ignite/pull/9630


   Thank you for submitting the pull request to the Apache Ignite.
   
   In order to streamline the review of the contribution 
   we ask you to ensure the following steps have been taken:
   
   ### The Contribution Checklist
   - [ ] There is a single JIRA ticket related to the pull request. 
   - [ ] The web-link to the pull request is attached to the JIRA ticket.
   - [ ] The JIRA ticket has the _Patch Available_ state.
   - [ ] The pull request body describes changes that have been made. 
   The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
   - [ ] The pull request title is treated as the final commit message. 
   The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
   - [ ] A reviewer has been mentioned through the JIRA comments 
   (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) 
   - [ ] The pull request has been checked by the Teamcity Bot and 
   the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
   
   ### Notes
   - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
   - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
   - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
   - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
   
   If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] vladErmakov07 closed pull request #9630: IGNITE-16057 Second read of array field from BinaryObject fail

[GitBox <gi...@apache.org>]

vladErmakov07 closed pull request #9630:
URL: https://github.com/apache/ignite/pull/9630


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on pull request #9630: IGNITE-16057 Second read of array field from BinaryObject fail

[GitBox <gi...@apache.org>]

nizhikov commented on pull request #9630:
URL: https://github.com/apache/ignite/pull/9630#issuecomment-992286639


   @vladErmakov07 Can you, please, extends your fix with the following:
   
   1. Extends tests with the `Collection`, `Map` and multidimensional array.
   2. Add the following scenario:
   
   ```
   private class TestClass {
       private MyClass field;
   
       private MyClass[] array;
   }
   
   //----
   
   TestClass t = new TestClass();
   
   t.field = new MyClass();
   t.array = new MyClass[] { new MyClass(), t.field, new Myclass() }
   
   TestClass t2 = serde(t);
   
   assertSame(t2.field, t2.array[1]);
   ```
   
   I think the root cause of the issue is - we don't move stream pointer to the end of the object when we read it with the handle. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org