You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2016/04/22 20:21:01 UTC
Review Request 46577: Fixed isolator cleaup issue when destroying a
provisioning container.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46577/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Jie Yu, Neil Conway, and Timothy Chen.
Bugs: MESOS-5253
https://issues.apache.org/jira/browse/MESOS-5253
Repository: mesos
Description
-------
Fixed isolator cleaup issue when destroying a provisioning container.
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp 1e1a36903f4377497bb72b69e4ead63675d453c0
Diff: https://reviews.apache.org/r/46577/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 46577: Fixed isolator cleaup issue when destroying
a provisioning container.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46577/#review130199
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46576, 46577]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 22, 2016, 6:21 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46577/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 6:21 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, Neil Conway, and Timothy Chen.
>
>
> Bugs: MESOS-5253
> https://issues.apache.org/jira/browse/MESOS-5253
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed isolator cleaup issue when destroying a provisioning container.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 1e1a36903f4377497bb72b69e4ead63675d453c0
>
> Diff: https://reviews.apache.org/r/46577/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 46577: Fixed isolator cleaup issue when destroying
a provisioning container.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46577/#review130207
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On April 22, 2016, 6:21 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46577/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 6:21 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, Neil Conway, and Timothy Chen.
>
>
> Bugs: MESOS-5253
> https://issues.apache.org/jira/browse/MESOS-5253
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed isolator cleaup issue when destroying a provisioning container.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 1e1a36903f4377497bb72b69e4ead63675d453c0
>
> Diff: https://reviews.apache.org/r/46577/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>