You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by te...@apache.org on 2013/02/21 02:18:46 UTC

svn commit: r1448485 - in /hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase: master/snapshot/ protobuf/ regionserver/snapshot/ snapshot/ zookeeper/

Author: tedyu
Date: Thu Feb 21 01:18:45 2013
New Revision: 1448485

URL: http://svn.apache.org/r1448485
Log:
HBASE-7889 Fix javadoc warnings in snapshot classes, part 2 (Ted Yu)

Modified:
    hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java
    hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
    hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/snapshot/RegionServerSnapshotManager.java
    hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java
    hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/TakeSnapshotUtils.java
    hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java

Modified: hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java
URL: http://svn.apache.org/viewvc/hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java?rev=1448485&r1=1448484&r2=1448485&view=diff
==============================================================================
--- hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java (original)
+++ hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java Thu Feb 21 01:18:45 2013
@@ -58,8 +58,8 @@ import org.apache.hadoop.hbase.util.FSUt
  * Further, the cache is periodically refreshed ensure that files in snapshots that were deleted are
  * also removed from the cache.
  * <p>
- * A {@link SnapshotFileInspector} must be passed when creating <tt>this</tt> to allow extraction
- * of files under the /hbase/.snapshot/[snapshot name] directory, for each snapshot.
+ * A {@link SnapshotFileCache.SnapshotFileInspector} must be passed when creating <tt>this</tt> to
+ * allow extraction of files under /hbase/.snapshot/[snapshot name] directory, for each snapshot.
  * This allows you to only cache files under, for instance, all the logs in the .logs directory or
  * all the files under all the regions.
  * <p>

Modified: hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
URL: http://svn.apache.org/viewvc/hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java?rev=1448485&r1=1448484&r2=1448485&view=diff
==============================================================================
--- hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java (original)
+++ hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java Thu Feb 21 01:18:45 2013
@@ -1015,7 +1015,7 @@ public final class RequestConverter {
   /**
    * Creates a protocol buffer GetSchemaAlterStatusRequest
    *
-   * @param table
+   * @param tableName
    * @return a GetSchemaAlterStatusRequest
    */
   public static GetSchemaAlterStatusRequest buildGetSchemaAlterStatusRequest(

Modified: hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/snapshot/RegionServerSnapshotManager.java
URL: http://svn.apache.org/viewvc/hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/snapshot/RegionServerSnapshotManager.java?rev=1448485&r1=1448484&r2=1448485&view=diff
==============================================================================
--- hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/snapshot/RegionServerSnapshotManager.java (original)
+++ hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/snapshot/RegionServerSnapshotManager.java Thu Feb 21 01:18:45 2013
@@ -66,7 +66,7 @@ import com.google.protobuf.InvalidProtoc
  * <p>
  * On startup, requires {@link #start()} to be called.
  * <p>
- * On shutdown, requires {@link #stop()} to be called
+ * On shutdown, requires {@link #stop(boolean)} to be called
  */
 @InterfaceAudience.Private
 @InterfaceStability.Unstable

Modified: hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java
URL: http://svn.apache.org/viewvc/hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java?rev=1448485&r1=1448484&r2=1448485&view=diff
==============================================================================
--- hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java (original)
+++ hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java Thu Feb 21 01:18:45 2013
@@ -67,7 +67,7 @@ import org.apache.hadoop.hbase.util.FSUt
  *
  * Utility methods in this class are useful for getting the correct locations for different parts of
  * the snapshot, as well as moving completed snapshots into place (see
- * {@link #completeSnapshot(SnapshotDescription, Path, Path, FileSystem)}, and writing the
+ * {@code #completeSnapshot(SnapshotDescription, Path, Path, FileSystem)}, and writing the
  * {@link SnapshotDescription} to the working snapshot directory.
  */
 public class SnapshotDescriptionUtils {

Modified: hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/TakeSnapshotUtils.java
URL: http://svn.apache.org/viewvc/hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/TakeSnapshotUtils.java?rev=1448485&r1=1448484&r2=1448485&view=diff
==============================================================================
--- hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/TakeSnapshotUtils.java (original)
+++ hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/TakeSnapshotUtils.java Thu Feb 21 01:18:45 2013
@@ -77,7 +77,7 @@ public class TakeSnapshotUtils {
    * <p>
    * Specific files per store are kept in a similar layout as per the current directory layout.
    * @param regionDir snapshot directory for the parent region, <b>not</b> the standard region
-   *          directory. See {@link #getRegionSnapshotDirectory(SnapshotDescription, Path, String)}
+   *          directory. See {@code #getRegionSnapshotDirectory(SnapshotDescription, Path, String)}
    * @param family name of the store to snapshot
    * @return path to the snapshot home directory for the store/family
    */

Modified: hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
URL: http://svn.apache.org/viewvc/hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java?rev=1448485&r1=1448484&r2=1448485&view=diff
==============================================================================
--- hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java (original)
+++ hbase/branches/hbase-7290v2/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java Thu Feb 21 01:18:45 2013
@@ -1752,7 +1752,7 @@ public class ZKUtil {
 
   /**
    * Helper method to print the current state of the ZK tree.
-   * @see #logZKTree(String)
+   * @see #logZKTree(ZooKeeperWatcher, String)
    * @throws KeeperException if an unexpected exception occurs
    */
   protected static void logZKTree(ZooKeeperWatcher zkw, String root, String prefix) throws KeeperException {