You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/01 13:28:45 UTC

[GitHub] [superset] villebro edited a comment on issue #16543: Multiple SQL metrics with auto-generated labels are collapsed into one

villebro edited a comment on issue #16543:
URL: https://github.com/apache/superset/issues/16543#issuecomment-910273644


   This is happening here: https://github.com/apache/superset/blob/80c39daa85c9be9e66a2e3cf2c9e2a8e5a74a8d6/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilter/index.js#L182
   
   The correct behavior should be to not physically truncate the label, but to visually handle the overflow with ellipsis. So the appearance should be unchanged like this:
   ![image](https://user-images.githubusercontent.com/33317356/131677214-3847524a-e87d-4d55-aa49-ae4ad260b3a4.png)
   
   with the label value being untruncated (currently this widens very ugly when exceeding 43 chars):
   ![image](https://user-images.githubusercontent.com/33317356/131677024-eb28aae7-649c-40e1-aefa-19c26c62d32d.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org