You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "John Sichi (JIRA)" <ji...@apache.org> on 2010/02/06 02:04:27 UTC
[jira] Created: (HIVE-1136) add type-checking setters for HiveConf
class to match existing getters
add type-checking setters for HiveConf class to match existing getters
----------------------------------------------------------------------
Key: HIVE-1136
URL: https://issues.apache.org/jira/browse/HIVE-1136
Project: Hadoop Hive
Issue Type: Improvement
Components: Configuration
Affects Versions: 0.6.0
Reporter: John Sichi
Assignee: John Sichi
Fix For: 0.6.0
This is a followup from HIVE-1129.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1136) add type-checking setters for
HiveConf class to match existing getters
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834482#action_12834482 ]
Zheng Shao commented on HIVE-1136:
----------------------------------
+1
Will test and commit.
> add type-checking setters for HiveConf class to match existing getters
> ----------------------------------------------------------------------
>
> Key: HIVE-1136
> URL: https://issues.apache.org/jira/browse/HIVE-1136
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 0.6.0
> Reporter: John Sichi
> Assignee: John Sichi
> Fix For: 0.6.0
>
> Attachments: HIVE-1136.1.patch
>
>
> This is a followup from HIVE-1129.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1136) Add type-checking setters for HiveConf
class to match existing getters
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1136:
---------------------------------
Affects Version/s: (was: 0.6.0)
Release Note: (was: HIVE-1136. Add type-checking setters for HiveConf class. (John Sichi via zshao))
Summary: Add type-checking setters for HiveConf class to match existing getters (was: add type-checking setters for HiveConf class to match existing getters)
> Add type-checking setters for HiveConf class to match existing getters
> ----------------------------------------------------------------------
>
> Key: HIVE-1136
> URL: https://issues.apache.org/jira/browse/HIVE-1136
> Project: Hive
> Issue Type: Improvement
> Components: Configuration
> Reporter: John Sichi
> Assignee: John Sichi
> Fix For: 0.6.0
>
> Attachments: HIVE-1136.1.patch, HIVE-1136.2.patch
>
>
> This is a followup from HIVE-1129.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1136) add type-checking setters for HiveConf
class to match existing getters
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-1136:
-----------------------------
Attachment: HIVE-1136.1.patch
> add type-checking setters for HiveConf class to match existing getters
> ----------------------------------------------------------------------
>
> Key: HIVE-1136
> URL: https://issues.apache.org/jira/browse/HIVE-1136
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 0.6.0
> Reporter: John Sichi
> Assignee: John Sichi
> Fix For: 0.6.0
>
> Attachments: HIVE-1136.1.patch
>
>
> This is a followup from HIVE-1129.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1136) add type-checking setters for
HiveConf class to match existing getters
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834526#action_12834526 ]
Zheng Shao commented on HIVE-1136:
----------------------------------
It seems that the following function is not in hadoop 0.17.
What about convert it to a string first? (and put a comment saying we did this for compatibility for hadoop 0.17)
{code}
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:303: cannot find symbol
[javac] symbol : method setFloat(java.lang.String,float)
[javac] location: class org.apache.hadoop.conf.Configuration
[javac] conf.setFloat(var.varname, val);
[javac] ^
{code}
> add type-checking setters for HiveConf class to match existing getters
> ----------------------------------------------------------------------
>
> Key: HIVE-1136
> URL: https://issues.apache.org/jira/browse/HIVE-1136
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 0.6.0
> Reporter: John Sichi
> Assignee: John Sichi
> Fix For: 0.6.0
>
> Attachments: HIVE-1136.1.patch
>
>
> This is a followup from HIVE-1129.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1136) add type-checking setters for
HiveConf class to match existing getters
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834562#action_12834562 ]
John Sichi commented on HIVE-1136:
----------------------------------
Per discussion with Zheng, added a new shim method to deal with the incompabitibility.
> add type-checking setters for HiveConf class to match existing getters
> ----------------------------------------------------------------------
>
> Key: HIVE-1136
> URL: https://issues.apache.org/jira/browse/HIVE-1136
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 0.6.0
> Reporter: John Sichi
> Assignee: John Sichi
> Fix For: 0.6.0
>
> Attachments: HIVE-1136.1.patch, HIVE-1136.2.patch
>
>
> This is a followup from HIVE-1129.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1136) add type-checking setters for HiveConf
class to match existing getters
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-1136:
-----------------------------
Attachment: (was: HIVE-1136.1.patch)
> add type-checking setters for HiveConf class to match existing getters
> ----------------------------------------------------------------------
>
> Key: HIVE-1136
> URL: https://issues.apache.org/jira/browse/HIVE-1136
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 0.6.0
> Reporter: John Sichi
> Assignee: John Sichi
> Fix For: 0.6.0
>
>
> This is a followup from HIVE-1129.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1136) add type-checking setters for HiveConf
class to match existing getters
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-1136:
-----------------------------
Status: Patch Available (was: Open)
This passed tests so I'm submitting it as ready.
> add type-checking setters for HiveConf class to match existing getters
> ----------------------------------------------------------------------
>
> Key: HIVE-1136
> URL: https://issues.apache.org/jira/browse/HIVE-1136
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 0.6.0
> Reporter: John Sichi
> Assignee: John Sichi
> Fix For: 0.6.0
>
> Attachments: HIVE-1136.1.patch
>
>
> This is a followup from HIVE-1129.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1136) add type-checking setters for HiveConf
class to match existing getters
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-1136:
-----------------------------
Attachment: (was: HIVE-1136.1.patch)
> add type-checking setters for HiveConf class to match existing getters
> ----------------------------------------------------------------------
>
> Key: HIVE-1136
> URL: https://issues.apache.org/jira/browse/HIVE-1136
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 0.6.0
> Reporter: John Sichi
> Assignee: John Sichi
> Fix For: 0.6.0
>
>
> This is a followup from HIVE-1129.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1136) add type-checking setters for HiveConf
class to match existing getters
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-1136:
-----------------------------
Attachment: HIVE-1136.1.patch
Finally uploaded the right patch.
> add type-checking setters for HiveConf class to match existing getters
> ----------------------------------------------------------------------
>
> Key: HIVE-1136
> URL: https://issues.apache.org/jira/browse/HIVE-1136
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 0.6.0
> Reporter: John Sichi
> Assignee: John Sichi
> Fix For: 0.6.0
>
> Attachments: HIVE-1136.1.patch
>
>
> This is a followup from HIVE-1129.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1136) add type-checking setters for HiveConf
class to match existing getters
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-1136:
-----------------------------
Attachment: HIVE-1136.2.patch
> add type-checking setters for HiveConf class to match existing getters
> ----------------------------------------------------------------------
>
> Key: HIVE-1136
> URL: https://issues.apache.org/jira/browse/HIVE-1136
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 0.6.0
> Reporter: John Sichi
> Assignee: John Sichi
> Fix For: 0.6.0
>
> Attachments: HIVE-1136.1.patch, HIVE-1136.2.patch
>
>
> This is a followup from HIVE-1129.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HIVE-1136) add type-checking setters for HiveConf
class to match existing getters
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao resolved HIVE-1136.
------------------------------
Resolution: Fixed
Release Note: HIVE-1136. Add type-checking setters for HiveConf class. (John Sichi via zshao)
Hadoop Flags: [Reviewed]
Committed. Thanks John!
> add type-checking setters for HiveConf class to match existing getters
> ----------------------------------------------------------------------
>
> Key: HIVE-1136
> URL: https://issues.apache.org/jira/browse/HIVE-1136
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 0.6.0
> Reporter: John Sichi
> Assignee: John Sichi
> Fix For: 0.6.0
>
> Attachments: HIVE-1136.1.patch, HIVE-1136.2.patch
>
>
> This is a followup from HIVE-1129.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1136) add type-checking setters for HiveConf
class to match existing getters
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-1136:
-----------------------------
Status: Open (was: Patch Available)
> add type-checking setters for HiveConf class to match existing getters
> ----------------------------------------------------------------------
>
> Key: HIVE-1136
> URL: https://issues.apache.org/jira/browse/HIVE-1136
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 0.6.0
> Reporter: John Sichi
> Assignee: John Sichi
> Fix For: 0.6.0
>
> Attachments: HIVE-1136.1.patch
>
>
> This is a followup from HIVE-1129.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1136) add type-checking setters for
HiveConf class to match existing getters
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834630#action_12834630 ]
Zheng Shao commented on HIVE-1136:
----------------------------------
+1. Will test and commit.
> add type-checking setters for HiveConf class to match existing getters
> ----------------------------------------------------------------------
>
> Key: HIVE-1136
> URL: https://issues.apache.org/jira/browse/HIVE-1136
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 0.6.0
> Reporter: John Sichi
> Assignee: John Sichi
> Fix For: 0.6.0
>
> Attachments: HIVE-1136.1.patch, HIVE-1136.2.patch
>
>
> This is a followup from HIVE-1129.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1136) add type-checking setters for HiveConf
class to match existing getters
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-1136:
-----------------------------
Attachment: HIVE-1136.1.patch
> add type-checking setters for HiveConf class to match existing getters
> ----------------------------------------------------------------------
>
> Key: HIVE-1136
> URL: https://issues.apache.org/jira/browse/HIVE-1136
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 0.6.0
> Reporter: John Sichi
> Assignee: John Sichi
> Fix For: 0.6.0
>
> Attachments: HIVE-1136.1.patch
>
>
> This is a followup from HIVE-1129.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.