You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/04 17:20:51 UTC

[GitHub] [beam] damccorm opened a new issue, #20430: Including TableProvider IO dependencies as `provided` can lead to ClassDefNotFoundErrors for users

damccorm opened a new issue, #20430:
URL: https://github.com/apache/beam/issues/20430

   The SQL extension uses ServiceLoader to load table providers: https://github.com/apache/beam/blob/v2.22.0/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/BeamCalciteSchemaFactory.java#L85
   
   And the IOs used in the built-in table providers (e.g. pubsub json, avro, parquet, ...) are included as `provided` dependencies, not `compile`. This means that we are able to build the sql extension jar, and AutoService picks them up and records them in META-INF/services. However because they are `provided` dependencies, the necessary IO modules are not marked as dependencies for the SQL extension.
   
   This means consumers of :sdks:java:extensions:sql (like :sdks:java:extensions:sql:jdbc) can end up with ServiceLoader registering a TableProvider that will fail with ClassDefNotFoundError, unless they add the necessary dependency.
   
   Possible solution: Refactor TableProvider to beam core (or another shared module) in order to solve Service Loader errors with SchemaCapableIOTableProviderWrapper. Remove getTableType overrides of SchemaCapableIOProviderWrapper when fixed.
   
   Imported from Jira [BEAM-10516](https://issues.apache.org/jira/browse/BEAM-10516). Original Jira may contain additional context.
   Reported by: slukas.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org