You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "hermya (via GitHub)" <gi...@apache.org> on 2024/10/09 00:30:19 UTC
[PR] Fixed flaky-test: StateTtlHintTest#testJoinStateTtlHintWithView [flink]
hermya opened a new pull request, #25464:
URL: https://github.com/apache/flink/pull/25464
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
**This pull request identifies a flaky-test and proposes a fix.**
## Brief change log
The following method asserts a flaky test:
**org.apache.flink.table.planner.plan.hints.stream.StateTtlHintTest#testJoinStateTtlHintWithView**
Failed assertion:
```
expected: <
Join(joinType=[InnerJoin], where=[=(a1, a3)], select=[a1, b1, a3, b3], leftInputSpec=[NoUniqueKey], rightInputSpec=[NoUniqueKey], stateTtlHints=[[[STATE_TTL options:{LEFT=2d, RIGHT=1d}]]])
:- Exchange(distribution=[hash[a1]])
: +- TableSourceScan(table=[[default_catalog, default_database, T1]], fields=[a1, b1])
+- Exchange(distribution=[hash[a3]])
+- TableSourceScan(table=[[default_catalog, default_database, T3]], fields=[a3, b3])
> but was: <
Join(joinType=[InnerJoin], where=[=(a1, a3)], select=[a1, b1, a3, b3], leftInputSpec=[NoUniqueKey], rightInputSpec=[NoUniqueKey], stateTtlHints=[[[STATE_TTL options:{RIGHT=1d, LEFT=2d}]]])
:- Exchange(distribution=[hash[a1]])
: +- TableSourceScan(table=[[default_catalog, default_database, T1]], fields=[a1, b1])
+- Exchange(distribution=[hash[a3]])
+- TableSourceScan(table=[[default_catalog, default_database, T3]], fields=[a3, b3])
>
```
### Precisely (String comparison failure)
```
Expected: stateTtlHints=[[[STATE_TTL options:{LEFT=2d, RIGHT=1d}]]]
Actual: stateTtlHints=[[[STATE_TTL options:{RIGHT=1d, LEFT=2d}]]]
```
### FAILURE REASON
RelExplainUtil.scala => hintsToString uses ImmutableMap.toString() function to convert kvOptions to string representation. Map.toString() is unreliable and gives non-deterministic output where sorting of Entries depends on current hashcode generation logic, and could be different for each toString call.
### Fix
Added a method that sorts entries in lexographical order and returns same result as map.toString(). Sorting makes it deterministic.
Confirmed test failure using nondex
### For particular test:
>mvn -pl ./flink-table/flink-table-planner edu.illinois:nondex-maven-plugin:2.1.7:nondex -Dtest=org.apache.flink.table.planner.plan.hints.stream.StateTtlHintTest#testJoinStateTtlHintWithView -DnondexRuns=10 -Dspotless.check.skip=true
### For entire repo
Suggested command to check flaky tests :
> mvn nondex:nondex
For more information : https://github.com/TestingResearchIllinois/NonDex
## Verifying this change
Please make sure both new and modified tests in this PR follow [the conventions for tests defined in our code quality guide](https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#7-testing).
This change added tests and can be verified as follows:
- Added fixes in code to generate deterministic output for non-flaky (deterministic) assertion
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Fixed flaky-test: StateTtlHintTest#testJoinStateTtlHintWithView [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25464:
URL: https://github.com/apache/flink/pull/25464#issuecomment-2401046430
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b289036cc1731c6ae08f25913b155fb0b774402",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1b289036cc1731c6ae08f25913b155fb0b774402",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b289036cc1731c6ae08f25913b155fb0b774402 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Fixed flaky-test: StateTtlHintTest#testJoinStateTtlHintWithView [flink]
Posted by "hermya (via GitHub)" <gi...@apache.org>.
hermya closed pull request #25464: [hotfix] Fixed flaky-test: StateTtlHintTest#testJoinStateTtlHintWithView
URL: https://github.com/apache/flink/pull/25464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org