You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2016/03/23 13:29:34 UTC
[GitHub] flink pull request: [FLINK-3524] [kafka] Add JSONDeserializationSc...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1834
[FLINK-3524] [kafka] Add JSONDeserializationSchema
This PR adds a JSON[KeyValue]DeserializationSchema to the kafka connector, which can be used to more easily read JSON data from Kafka. Instead of having to read them as strings and creating parsers themselves a user can now delegeta this to the DeserializationSchema, saving the string allocation and possible instantiation of multiple parser factories.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 3524_json_schema
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1834.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1834
----
commit 536b2888f1f8fa0a76753e0245378ceb0d242ef1
Author: zentol <ch...@apache.org>
Date: 2016-03-23T10:24:50Z
[FLINK-3524] [kafka] Add JSONDeserializationSchema
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3524] [kafka] Add JSONDeserializationSc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1834
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3524] [kafka] Add JSONDeserializationSc...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1834#issuecomment-205303136
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3524] [kafka] Add JSONDeserializationSc...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1834#issuecomment-200330964
Can you quickly mention the class in the Kafka documentation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3524] [kafka] Add JSONDeserializationSc...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1834#issuecomment-203335575
@StephanEwen yes, it's only for kafka. it relies on other classes (KeyedDeserializationSchema) that are only present in the kafka module.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3524] [kafka] Add JSONDeserializationSc...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1834#issuecomment-200330990
Otherwise, the change looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3524] [kafka] Add JSONDeserializationSc...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1834#issuecomment-200795303
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3524] [kafka] Add JSONDeserializationSc...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1834#issuecomment-202964440
Looks good.
Is this a Kafka-only util?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---