[GitHub] rafaelweingartner commented on a change in pull request #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox <gi...@apache.org>]

rafaelweingartner commented on a change in pull request #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r184948864
 
 

 ##########
 File path: server/src/com/cloud/network/vpc/VpcManagerImpl.java
 ##########
 @@ -1508,19 +1519,33 @@ public boolean restartVpc(final long vpcId, final boolean cleanUp, final boolean
 
                 // Change the VPC in order to get it updated after the end of
                 // the restart procedure.
-                _vpcDao.update(vpc.getId(), entity);
+                if (_vpcDao.update(vpc.getId(), entity)) {
+                    vpc = entity;
+                }
 
                 // If the offering and redundant column are changing, force the
                 // clean up.
                 forceCleanup = true;
             }
 
             if (forceCleanup) {
 
 Review comment:
   Yes it is, if you consider only the body of the IF, but eh method is already quite big.  The more we extract, the more unit tests we enable. Moreover, it becomes easier to read the code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services