You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2021/04/24 08:06:59 UTC
[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #215: Remove channels, prefer async style
codecov[bot] commented on pull request #215:
URL: https://github.com/apache/incubator-tuweni/pull/215#issuecomment-826054818
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/215?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#215](https://codecov.io/gh/apache/incubator-tuweni/pull/215?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4c7da67) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/7fc9a69b0b8e72d562a8827cdb35a510b5300a1e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7fc9a69) will **increase** coverage by `0.07%`.
> The diff coverage is `37.93%`.
> :exclamation: Current head 4c7da67 differs from pull request most recent head e7331ce. Consider uploading reports for the commit e7331ce to get more accurate results
[](https://codecov.io/gh/apache/incubator-tuweni/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #215 +/- ##
============================================
+ Coverage 60.25% 60.33% +0.07%
Complexity 4003 4003
============================================
Files 385 385
Lines 21451 21418 -33
Branches 2860 2853 -7
============================================
- Hits 12926 12922 -4
+ Misses 7073 7048 -25
+ Partials 1452 1448 -4
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| unit | `60.33% <37.93%> (+0.07%)` | `4003.00 <0.00> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `50.88% <37.93%> (+3.20%)` | `0.00 <0.00> (ø)` | |
| [.../kotlin/org/apache/tuweni/jsonrpc/JSONRPCClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9KU09OUlBDQ2xpZW50Lmt0) | `50.00% <0.00%> (-1.93%)` | `4.00% <0.00%> (ø%)` | |
| [.../main/java/org/apache/tuweni/crypto/SECP256K1.java](https://codecov.io/gh/apache/incubator-tuweni/pull/215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL1NFQ1AyNTZLMS5qYXZh) | `72.46% <0.00%> (-0.81%)` | `19.00% <0.00%> (ø%)` | |
| [...he/tuweni/concurrent/coroutines/AsyncCompletion.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNDb21wbGV0aW9uLmt0) | `69.64% <0.00%> (+1.78%)` | `0.00% <0.00%> (ø%)` | |
| [...apache/tuweni/concurrent/coroutines/AsyncResult.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNSZXN1bHQua3Q=) | `80.85% <0.00%> (+2.12%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/215?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/215?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7fc9a69...e7331ce](https://codecov.io/gh/apache/incubator-tuweni/pull/215?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org