You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "W-M-R (via GitHub)" <gi...@apache.org> on 2024/10/22 12:41:55 UTC

[PR] kconfig: Add link parameters that can print remaining memory information [nuttx]

W-M-R opened a new pull request, #14452:
URL: https://github.com/apache/nuttx/pull/14452

   ## Summary
   LD: nuttx
   Memory region         Used Size  Region Size  %age Used
              flash:      284272 B       512 KB     54.22%
              sram1:       13296 B         2 MB      0.63%
              sram2:          0 GB         2 MB      0.00%
   CP: nuttx.hex
   CP: nuttx.bin
   ## Impact
   ## Testing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] kconfig: Add link parameters that can print remaining memory information [nuttx]

Posted by "W-M-R (via GitHub)" <gi...@apache.org>.
W-M-R commented on PR #14452:
URL: https://github.com/apache/nuttx/pull/14452#issuecomment-2430678312

   > @W-M-R why don't we just add is by default instead of depending on Kconfig? Every user needs it and we can use it in the CI to warn about board profiles that are reaching the flash limit.
   > 
   > @JorgeGzm see now we have what you was planing to add some time ago
   
   For example, the boards/arm/qemu/qemu-armv7a/scripts/dramboot.ld link script is written in a way that it is not possible to print out the usage information of each memory, so I did not turn it on by default.It print like:
   
   LD: nuttx
   Memory region         Used Size  Region Size  %age Used
   CP: nuttx.hex
   CP: nuttx.bin
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] kconfig: Add link parameters that can print remaining memory information [nuttx]

Posted by "W-M-R (via GitHub)" <gi...@apache.org>.
W-M-R commented on PR #14452:
URL: https://github.com/apache/nuttx/pull/14452#issuecomment-2432412103

   > @W-M-R I think you need to ignore the parameter for SIM board/arch:
   > 
   > ```
   > aarch64-none-elf-g++: error: unrecognized command-line option '--print-memory-usage'
   > ninja: build stopped: subcommand failed.
   > cp: cannot stat 'nuttx.hex': No such file or directory
   > cp: cannot stat 'nuttx.bin': No such file or directory
   > ```
   
   OK


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] kconfig: Add link parameters that can print remaining memory information [nuttx]

Posted by "W-M-R (via GitHub)" <gi...@apache.org>.
W-M-R commented on PR #14452:
URL: https://github.com/apache/nuttx/pull/14452#issuecomment-2432060419

   > @W-M-R maybe you can just ignore if for boards that doesn't support it. Since it is something that doesn't increase the final binary and it is very useful for all users. Others RTOSes show the memory footprint by default at end of compilation也许您可以忽略不支持它的主板。因为它不会增加最终的二进制文件,并且对所有用户都非常有用。其他 RTOS 在编译结束时默认显示内存占用量
   
   Is it to enable it by default, or not to rely on any config?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] kconfig: Add link parameters that can print remaining memory information [nuttx]

Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on PR #14452:
URL: https://github.com/apache/nuttx/pull/14452#issuecomment-2434394428

   > > @W-M-R I think you need to ignore the parameter for SIM board/arch:
   > > ```
   > > aarch64-none-elf-g++: error: unrecognized command-line option '--print-memory-usage'
   > > ninja: build stopped: subcommand failed.
   > > cp: cannot stat 'nuttx.hex': No such file or directory
   > > cp: cannot stat 'nuttx.bin': No such file or directory
   > > ```
   > 
   > This may be cmake cannot be used, because the cmake connector is gcc or g++.I removed them from cmake
   
   You could set the command-line option to "`-Wl,--print-memory-usage`" in cmake, which pass "`--print-memory-usage`" as an option to the linker


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] kconfig: Add link parameters that can print remaining memory information [nuttx]

Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #14452:
URL: https://github.com/apache/nuttx/pull/14452#issuecomment-2429205681

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   The provided PR information is **incomplete** and **does not meet the NuttX requirements.**
   
   Here's why:
   
   * **Missing crucial information in the Summary:**
       * **Reason for change:** Is this a fix, update, or new feature?
       * **Functionality affected:** Which part of the codebase is being modified?
       * **How the change works:**  Provide a clear explanation of the changes made and their effects.
       * **Issue/PR references:**  Link any relevant issues or PRs.
   * **Impact section lacks details:**  
       * All impact points simply state "NO" without providing justification or explaining potential changes. 
   * **Testing section is insufficient:**
       * **Missing build host details:** Provide specifics about your development environment.
       * **Target information is vague:** Specify the architecture, board, and configuration used for testing.
       * **Testing logs are placeholders:** Include actual logs from before and after the change to demonstrate its impact. 
   
   **To meet NuttX PR requirements, you need to:**
   
   1. **Complete the Summary section** with specific details about the change.
   2. **Thoroughly address each impact point.**  If an impact is "NO", briefly explain why. If "YES", provide a clear description of the impact.
   3. **Provide comprehensive testing information:** Include detailed build host and target specifications and replace placeholder logs with actual test output. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] kconfig: Add link parameters that can print remaining memory information [nuttx]

Posted by "W-M-R (via GitHub)" <gi...@apache.org>.
W-M-R commented on PR #14452:
URL: https://github.com/apache/nuttx/pull/14452#issuecomment-2432126726

   > @W-M-R I think we don't even need a config for it, just keep is something expected at the end of the build process, like others RTOSes do
   
   OK


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] kconfig: Add link parameters that can print remaining memory information [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #14452:
URL: https://github.com/apache/nuttx/pull/14452#issuecomment-2432012674

   @W-M-R maybe you can just ignore if for boards that doesn't support it. Since it is something that doesn't increase the final binary and it is very useful for all users. Others RTOSes show the memory footprint by default at end of compilation


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] kconfig: Add link parameters that can print remaining memory information [nuttx]

Posted by "W-M-R (via GitHub)" <gi...@apache.org>.
W-M-R commented on PR #14452:
URL: https://github.com/apache/nuttx/pull/14452#issuecomment-2432125644

   > LD: nuttx
   > Memory region         Used Size  Region Size  %age Used
   >            flash:      284272 B       512 KB     54.22%
   >            sram1:       13296 B         2 MB      0.63%
   >            sram2:          0 GB         2 MB      0.00%
   > CP: nuttx.hex
   > CP: nuttx.bin
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] kconfig: Add link parameters that can print remaining memory information [nuttx]

Posted by "W-M-R (via GitHub)" <gi...@apache.org>.
W-M-R commented on PR #14452:
URL: https://github.com/apache/nuttx/pull/14452#issuecomment-2434622173

   > This may be cmake cannot be used, because the cmake connector is gcc or g++.I removed them from cmake
   
   ok, that's right, thanks brother chao.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] kconfig: Add link parameters that can print remaining memory information [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #14452:
URL: https://github.com/apache/nuttx/pull/14452#issuecomment-2432349390

   @W-M-R I think you need to ignore the parameter for SIM board/arch:
   
   ```
   aarch64-none-elf-g++: error: unrecognized command-line option '--print-memory-usage'
   ninja: build stopped: subcommand failed.
   cp: cannot stat 'nuttx.hex': No such file or directory
   cp: cannot stat 'nuttx.bin': No such file or directory
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] kconfig: Add link parameters that can print remaining memory information [nuttx]

Posted by "W-M-R (via GitHub)" <gi...@apache.org>.
W-M-R commented on PR #14452:
URL: https://github.com/apache/nuttx/pull/14452#issuecomment-2432396165

   > @W-M-R I think you need to ignore the parameter for SIM board/arch:
   > 
   > ```
   > aarch64-none-elf-g++: error: unrecognized command-line option '--print-memory-usage'
   > ninja: build stopped: subcommand failed.
   > cp: cannot stat 'nuttx.hex': No such file or directory
   > cp: cannot stat 'nuttx.bin': No such file or directory
   > ```
   
   This may cmake cannot be used, because the cmake connector is gcc or g++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] kconfig: Add link parameters that can print remaining memory information [nuttx]

Posted by "W-M-R (via GitHub)" <gi...@apache.org>.
W-M-R closed pull request #14452: kconfig: Add link parameters that can print remaining memory information
URL: https://github.com/apache/nuttx/pull/14452


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] kconfig: Add link parameters that can print remaining memory information [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #14452:
URL: https://github.com/apache/nuttx/pull/14452#issuecomment-2430002276

   @W-M-R why don't we just add is by default instead of depending on Kconfig? Every user needs it and we can use it in the CI to warn about board profiles that are reaching the flash limit.
   
   @JorgeGzm see now we have what you was planing to add some time ago


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] kconfig: Add link parameters that can print remaining memory information [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #14452:
URL: https://github.com/apache/nuttx/pull/14452#issuecomment-2432075056

   @W-M-R I think we don't even need a config for it, just keep is something expected at the end of the build process, like others RTOSes do


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] kconfig: Add link parameters that can print remaining memory information [nuttx]

Posted by "W-M-R (via GitHub)" <gi...@apache.org>.
W-M-R commented on PR #14452:
URL: https://github.com/apache/nuttx/pull/14452#issuecomment-2432060775

   > > @W-M-R maybe you can just ignore if for boards that doesn't support it. Since it is something that doesn't increase the final binary and it is very useful for all users. Others RTOSes show the memory footprint by default at end of compilation
   > 
   > Is it to enable it by default, or not to rely on any config?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] kconfig: Add link parameters that can print remaining memory information [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #14452:
URL: https://github.com/apache/nuttx/pull/14452


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org