You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2021/10/08 00:05:05 UTC

[kudu-CR] [master] KUDU-1885: re-resolve TSDescriptor proxies on network error 

Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17909


Change subject: [master] KUDU-1885: re-resolve TSDescriptor proxies on network error
......................................................................

[master] KUDU-1885: re-resolve TSDescriptor proxies on network error

This patch uses the capabilities added in KUDU-75 to add the ability for
the master to re-resolve the addresses of tablet servers if its requests
fail.

Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef
---
M src/kudu/integration-tests/dns_alias-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
M src/kudu/master/ts_descriptor.cc
M src/kudu/master/ts_descriptor.h
5 files changed, 90 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/17909/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef
Gerrit-Change-Number: 17909
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>

[kudu-CR] [master] KUDU-1885: re-resolve TSDescriptor proxies on network error

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.

Change subject: [master] KUDU-1885: re-resolve TSDescriptor proxies on network error
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/17909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef
Gerrit-Change-Number: 17909
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [master] KUDU-1885: re-resolve TSDescriptor proxies on network error

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17909 )

Change subject: [master] KUDU-1885: re-resolve TSDescriptor proxies on network error
......................................................................


Patch Set 6: Code-Review+2

Thank you for addressing those nits!


-- 
To view, visit http://gerrit.cloudera.org:8080/17909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef
Gerrit-Change-Number: 17909
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 08 Oct 2021 21:11:32 +0000
Gerrit-HasComments: No

[kudu-CR] [master] KUDU-1885: re-resolve TSDescriptor proxies on network error

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17909 )

Change subject: [master] KUDU-1885: re-resolve TSDescriptor proxies on network error
......................................................................


Patch Set 6: Verified+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17909/5/src/kudu/integration-tests/dns_alias-itest.cc
File src/kudu/integration-tests/dns_alias-itest.cc:

http://gerrit.cloudera.org:8080/#/c/17909/5/src/kudu/integration-tests/dns_alias-itest.cc@384
PS5, Line 384: 
> IIRC, catalog manager doesn't assign tablet replicas to a tablet server it 
Added a comment. The default is 60 seconds to be considered unresponsive.

Also looped this 500 times and it passed 100%.


http://gerrit.cloudera.org:8080/#/c/17909/5/src/kudu/integration-tests/dns_alias-itest.cc@421
PS5, Line 421: auto tserver_proxy = cluster_->tserver_proxy(cluster_->num_tabl
> nit: does it make sense to add check for resp.has_error() as well just for 
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/17909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef
Gerrit-Change-Number: 17909
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 08 Oct 2021 21:40:18 +0000
Gerrit-HasComments: Yes

[kudu-CR] [master] KUDU-1885: re-resolve TSDescriptor proxies on network error

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17909 )

Change subject: [master] KUDU-1885: re-resolve TSDescriptor proxies on network error
......................................................................

[master] KUDU-1885: re-resolve TSDescriptor proxies on network error

This patch uses the capabilities added in KUDU-75 to add the ability for
the master to re-resolve the addresses of tablet servers if its requests
fail.

Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef
Reviewed-on: http://gerrit.cloudera.org:8080/17909
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/integration-tests/dns_alias-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
M src/kudu/master/ts_descriptor.cc
4 files changed, 92 insertions(+), 9 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Andrew Wong: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef
Gerrit-Change-Number: 17909
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [master] KUDU-1885: re-resolve TSDescriptor proxies on network error

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17909

to look at the new patch set (#6).

Change subject: [master] KUDU-1885: re-resolve TSDescriptor proxies on network error
......................................................................

[master] KUDU-1885: re-resolve TSDescriptor proxies on network error

This patch uses the capabilities added in KUDU-75 to add the ability for
the master to re-resolve the addresses of tablet servers if its requests
fail.

Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef
---
M src/kudu/integration-tests/dns_alias-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
M src/kudu/master/ts_descriptor.cc
4 files changed, 92 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/17909/6
-- 
To view, visit http://gerrit.cloudera.org:8080/17909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef
Gerrit-Change-Number: 17909
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [master] KUDU-1885: re-resolve TSDescriptor proxies on network error

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17909 )

Change subject: [master] KUDU-1885: re-resolve TSDescriptor proxies on network error
......................................................................


Patch Set 5: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17909/5/src/kudu/integration-tests/dns_alias-itest.cc
File src/kudu/integration-tests/dns_alias-itest.cc:

http://gerrit.cloudera.org:8080/#/c/17909/5/src/kudu/integration-tests/dns_alias-itest.cc@384
PS5, Line 384: to the tserver with a new address
IIRC, catalog manager doesn't assign tablet replicas to a tablet server it knows is down (controlled by the  --tserver_unresponsive_timeout_ms).  Maybe, add a blurb explaining that catalog manager isn't able to see the change in the state of the tserver because of the default setting for --tserver_unresponsive_timeout_ms ?

BTW, did you see any flakiness in this scenario when running in TSAN configuration?  If so, does it make sense to increase --tserver_unresponsive_timeout_ms setting for master?


http://gerrit.cloudera.org:8080/#/c/17909/5/src/kudu/integration-tests/dns_alias-itest.cc@421
PS5, Line 421: ASSERT_OK(tserver_proxy->ListTablets(req, &resp, &controller));
nit: does it make sense to add check for resp.has_error() as well just for easier debugging if the call fails?



-- 
To view, visit http://gerrit.cloudera.org:8080/17909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef
Gerrit-Change-Number: 17909
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 08 Oct 2021 19:30:18 +0000
Gerrit-HasComments: Yes

[kudu-CR] [master] KUDU-1885: re-resolve TSDescriptor proxies on network error

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17909

to look at the new patch set (#2).

Change subject: [master] KUDU-1885: re-resolve TSDescriptor proxies on network error
......................................................................

[master] KUDU-1885: re-resolve TSDescriptor proxies on network error

This patch uses the capabilities added in KUDU-75 to add the ability for
the master to re-resolve the addresses of tablet servers if its requests
fail.

Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef
---
M src/kudu/integration-tests/dns_alias-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
M src/kudu/master/ts_descriptor.cc
M src/kudu/master/ts_descriptor.h
5 files changed, 90 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/17909/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef
Gerrit-Change-Number: 17909
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [master] KUDU-1885: re-resolve TSDescriptor proxies on network error

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17909

to look at the new patch set (#4).

Change subject: [master] KUDU-1885: re-resolve TSDescriptor proxies on network error
......................................................................

[master] KUDU-1885: re-resolve TSDescriptor proxies on network error

This patch uses the capabilities added in KUDU-75 to add the ability for
the master to re-resolve the addresses of tablet servers if its requests
fail.

Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef
---
M src/kudu/integration-tests/dns_alias-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
M src/kudu/master/ts_descriptor.cc
M src/kudu/master/ts_descriptor.h
5 files changed, 100 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/17909/4
-- 
To view, visit http://gerrit.cloudera.org:8080/17909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef
Gerrit-Change-Number: 17909
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [master] KUDU-1885: re-resolve TSDescriptor proxies on network error

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17909 )

Change subject: [master] KUDU-1885: re-resolve TSDescriptor proxies on network error
......................................................................


Patch Set 5: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef
Gerrit-Change-Number: 17909
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 08 Oct 2021 18:12:49 +0000
Gerrit-HasComments: No

[kudu-CR] [master] KUDU-1885: re-resolve TSDescriptor proxies on network error

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.

Change subject: [master] KUDU-1885: re-resolve TSDescriptor proxies on network error
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/17909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef
Gerrit-Change-Number: 17909
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [master] KUDU-1885: re-resolve TSDescriptor proxies on network error

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17909 )

Change subject: [master] KUDU-1885: re-resolve TSDescriptor proxies on network error
......................................................................


Patch Set 5: Verified+1

Unrelated test:
  ConcurrentRebalancersTest.TwoConcurrentRebalancers/1

And IWYU is complaining about a file that is no longer updated in the latest patch set.


-- 
To view, visit http://gerrit.cloudera.org:8080/17909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef
Gerrit-Change-Number: 17909
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 08 Oct 2021 18:25:54 +0000
Gerrit-HasComments: No

[kudu-CR] [master] KUDU-1885: re-resolve TSDescriptor proxies on network error

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17909

to look at the new patch set (#5).

Change subject: [master] KUDU-1885: re-resolve TSDescriptor proxies on network error
......................................................................

[master] KUDU-1885: re-resolve TSDescriptor proxies on network error

This patch uses the capabilities added in KUDU-75 to add the ability for
the master to re-resolve the addresses of tablet servers if its requests
fail.

Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef
---
M src/kudu/integration-tests/dns_alias-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
M src/kudu/master/ts_descriptor.cc
4 files changed, 86 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/17909/5
-- 
To view, visit http://gerrit.cloudera.org:8080/17909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef
Gerrit-Change-Number: 17909
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [master] KUDU-1885: re-resolve TSDescriptor proxies on network error

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17909

to look at the new patch set (#3).

Change subject: [master] KUDU-1885: re-resolve TSDescriptor proxies on network error
......................................................................

[master] KUDU-1885: re-resolve TSDescriptor proxies on network error

This patch uses the capabilities added in KUDU-75 to add the ability for
the master to re-resolve the addresses of tablet servers if its requests
fail.

Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef
---
M src/kudu/integration-tests/dns_alias-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
M src/kudu/master/ts_descriptor.cc
M src/kudu/master/ts_descriptor.h
5 files changed, 94 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/17909/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6245f75a232fd4827de684cfc04d6b6e53b7ddef
Gerrit-Change-Number: 17909
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)