[GitHub] [iceberg] lcspinter commented on a change in pull request #2350: Fix broken TestHiveClientPool

[GitBox <gi...@apache.org>]

lcspinter commented on a change in pull request #2350:
URL: https://github.com/apache/iceberg/pull/2350#discussion_r596744374



##########
File path: hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveClientPool.java
##########
@@ -44,7 +44,7 @@ public void testConf() {
     conf.set(HiveConf.ConfVars.METASTOREWAREHOUSE.varname, "file:/mywarehouse/");
     conf.setInt("iceberg.hive.client-pool-size", 10);
 
-    HiveClientPool clientPool = new HiveClientPool(conf);
+    HiveClientPool clientPool = new HiveClientPool(10, conf);

Review comment:
       Previously we had a HiveClientPool constructor, which got the client-pool-size from the hive conf. This was removed, and now it expects the pool-size explicitly. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org