[GitHub] [superset] zhaoyongjie commented on a diff in pull request #21847: fix: custom SQL in the XAxis

[GitBox <gi...@apache.org>]

zhaoyongjie commented on code in PR #21847:
URL: https://github.com/apache/superset/pull/21847#discussion_r998863028


##########
superset-frontend/packages/superset-ui-chart-controls/src/operators/pivotOperator.ts:
##########
@@ -30,7 +30,7 @@ export const pivotOperator: PostProcessingFactory<PostProcessingPivot> = (
   queryObject,
 ) => {
   const metricLabels = ensureIsArray(queryObject.metrics).map(getMetricLabel);
-  const xAxis = getXAxis(formData);
+  const xAxis = getXAxisLabel(formData);

Review Comment:
   I have to use `getXAxisLabel` and `getXAxixColumn` because exist some naming conflicts. Another reason is explicitly naming a function rather than a variable.
   
   <img width="1127" alt="image" src="https://user-images.githubusercontent.com/2016594/196577484-51f7f54b-fbbb-4498-b43d-29665c4bd2bd.png">
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org