[GitHub] [spark] yaooqinn commented on a change in pull request #34920: [SPARK-37661][SQL] SparkSQLCLIDriver shall avoid using hive defaults to resolve warehouse dir

[GitBox <gi...@apache.org>]

yaooqinn commented on a change in pull request #34920:
URL: https://github.com/apache/spark/pull/34920#discussion_r770342116



##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##########
@@ -144,11 +143,6 @@ private[hive] class HiveClientImpl(
       // its own state by newState()
       val ret = SessionState.get
       if (ret != null) {
-        // hive.metastore.warehouse.dir is determined in SharedState after the CliSessionState

Review comment:
       When the dir is correctly set, it's not needed any more 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org