[GitHub] [kafka] junrao commented on a change in pull request #8974: KAFKA-10225 Increase default zk session timeout for system tests

[GitBox <gi...@apache.org>]

junrao commented on a change in pull request #8974:
URL: https://github.com/apache/kafka/pull/8974#discussion_r450419922



##########
File path: tests/kafkatest/services/kafka/kafka.py
##########
@@ -185,7 +185,11 @@ def __init__(self, context, num_nodes, zk, security_protocol=SecurityConfig.PLAI
 
         for node in self.nodes:
             node.version = version
-            node.config = KafkaConfig(**{config_property.BROKER_ID: self.idx(node)})
+            node.config = KafkaConfig(**{
+                config_property.BROKER_ID: self.idx(node),
+                config_property.ZOOKEEPER_CONNECTION_TIMEOUT_MS: zk_connect_timeout,

Review comment:
       Could we change the default ZK session timeout and ZK connection timeout in line 101 to 18 secs too?

##########
File path: tests/kafkatest/services/kafka/config.py
##########
@@ -25,7 +25,8 @@ class KafkaConfig(dict):
         config_property.PORT: 9092,
         config_property.SOCKET_RECEIVE_BUFFER_BYTES: 65536,
         config_property.LOG_DIRS: "/mnt/kafka/kafka-data-logs-1,/mnt/kafka/kafka-data-logs-2",
-        config_property.ZOOKEEPER_CONNECTION_TIMEOUT_MS: 2000
+        config_property.ZOOKEEPER_CONNECTION_TIMEOUT_MS: 5000,
+        config_property.ZOOKEEPER_SESSION_TIMEOUT_MS: 6000

Review comment:
       The default ZK session timeout and ZK connection timeout are both 18 secs. So we can just change both to 18secs here. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org