[jira] [Commented] (STORM-1885) python script for squashing and merging prs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316925#comment-15316925 ] 

ASF GitHub Bot commented on STORM-1885:
---------------------------------------

Github user ptgoetz commented on the issue:

    https://github.com/apache/storm/pull/1468
  
    I'm a little on the fence in terms of squashing the commits of others vs. asking the contributor to do so. There are a lot of situations where spreading out a big patch over multiple commits makes sense and makes the history more consumable. 
    
    A couple of questions:
    * How does this preserve authorship in a pull request that has commits from multiple authors?
    * How would this work with our current branch model? Specifically, applying a pull request to multiple branches.



> python script for squashing and merging prs
> -------------------------------------------
>
>                 Key: STORM-1885
>                 URL: https://issues.apache.org/jira/browse/STORM-1885
>             Project: Apache Storm
>          Issue Type: Task
>            Reporter: Sriharsha Chintalapani
>            Assignee: Sriharsha Chintalapani
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)