[GitHub] [incubator-devlake] keon94 commented on a diff in pull request #3761: Don't check network connection when service is behind a proxy

[GitBox <gi...@apache.org>]

keon94 commented on code in PR #3761:
URL: https://github.com/apache/incubator-devlake/pull/3761#discussion_r1026793254


##########
plugins/helper/api_client.go:
##########
@@ -84,10 +84,13 @@ func NewApiClient(
 	if err != nil {
 		return nil, errors.Default.New("Failed to resolve Port")
 	}
-	err = utils.CheckNetwork(parsedUrl.Hostname(), port, 10*time.Second)
-	if err != nil {
-		return nil, errors.Default.Wrap(err, "Failed to connect")
-	}
+
+    if proxy != "" {

Review Comment:
   I'm not sure we'd want to skip checking the connection altogether. Could we not just call CheckNetwork() on the proxy instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org