You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@curator.apache.org by Jordan Zimmerman <jo...@jordanzimmerman.com> on 2016/02/08 15:50:23 UTC

https://github.com/apache/curator/pull/131

I’d like to merge https://github.com/apache/curator/pull/131 - any comments before I do?

-Jordan

Re: https://github.com/apache/curator/pull/131

Posted by Jordan Zimmerman <jo...@jordanzimmerman.com>.

I use IntelliJ to generate the equals/hashCode so it’s not always optimum.

> On Feb 8, 2016, at 12:42 PM, Scott Blum <dr...@gmail.com> wrote:
> 
> I threw down some minor comments, sorry I don't have more context on the
> major pieces.  That said, if all the tests are passing, that seems like a
> strong indicator of success!
> 
> On Mon, Feb 8, 2016 at 9:50 AM, Jordan Zimmerman <jordan@jordanzimmerman.com
>> wrote:
> 
>> I’d like to merge https://github.com/apache/curator/pull/131 - any
>> comments before I do?
>> 
>> -Jordan

Re: https://github.com/apache/curator/pull/131

Posted by Scott Blum <dr...@gmail.com>.

I threw down some minor comments, sorry I don't have more context on the
major pieces.  That said, if all the tests are passing, that seems like a
strong indicator of success!

On Mon, Feb 8, 2016 at 9:50 AM, Jordan Zimmerman <jordan@jordanzimmerman.com
> wrote:

> I’d like to merge https://github.com/apache/curator/pull/131 - any
> comments before I do?
>
> -Jordan