You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Harold Dost <h....@criteo.com> on 2018/03/20 14:34:48 UTC
Review Request 66173: Add test for new `disk/xfs` kill functionality.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66173/
-----------------------------------------------------------
Review request for mesos and James Peach.
Bugs: MESOS-6575
https://issues.apache.org/jira/browse/MESOS-6575
Repository: mesos
Description
-------
MESOS-6575
Diffs
-----
src/tests/containerizer/xfs_quota_tests.cpp 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe
Diff: https://reviews.apache.org/r/66173/diff/1/
Testing
-------
Thanks,
Harold Dost
Re: Review Request 66173: Add test for new `disk/xfs` kill
functionality.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66173/#review199554
-----------------------------------------------------------
PASS: Mesos patch 66173 was successfully built and tested.
Reviews applied: `['66001', '66173']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66173
- Mesos Reviewbot Windows
On March 20, 2018, 2:34 p.m., Harold Dost wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66173/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 2:34 p.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-6575
> https://issues.apache.org/jira/browse/MESOS-6575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-6575
>
>
> Diffs
> -----
>
> src/tests/containerizer/xfs_quota_tests.cpp 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe
>
>
> Diff: https://reviews.apache.org/r/66173/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harold Dost
>
>
Re: Review Request 66173: Add test for new `disk/xfs` kill
functionality.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66173/#review199794
-----------------------------------------------------------
In one of the basic quota tests (maybe ROOT_XFS_QuotaTest.QuotaGetSet) we should add a check to verify that the hard & soft limits get set correctly.
- James Peach
On March 22, 2018, 2:11 p.m., Harold Dost wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66173/
> -----------------------------------------------------------
>
> (Updated March 22, 2018, 2:11 p.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-6575
> https://issues.apache.org/jira/browse/MESOS-6575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-6575
>
>
> Diffs
> -----
>
> src/tests/containerizer/xfs_quota_tests.cpp 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe
>
>
> Diff: https://reviews.apache.org/r/66173/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harold Dost
>
>
Re: Review Request 66173: Add test for new `disk/xfs` kill
functionality.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66173/#review200474
-----------------------------------------------------------
PASS: Mesos patch 66173 was successfully built and tested.
Reviews applied: `['66001', '66173']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66173
- Mesos Reviewbot Windows
On April 4, 2018, 5:41 p.m., Harold Dost wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66173/
> -----------------------------------------------------------
>
> (Updated April 4, 2018, 5:41 p.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-6575
> https://issues.apache.org/jira/browse/MESOS-6575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-6575
>
>
> Diffs
> -----
>
> src/tests/containerizer/xfs_quota_tests.cpp 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe
>
>
> Diff: https://reviews.apache.org/r/66173/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harold Dost
>
>
Re: Review Request 66173: Add test for new `disk/xfs` kill
functionality.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66173/#review201956
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66001, 66173]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 20, 2018, 8:49 p.m., Harold Dost wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66173/
> -----------------------------------------------------------
>
> (Updated April 20, 2018, 8:49 p.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-6575
> https://issues.apache.org/jira/browse/MESOS-6575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-6575
>
>
> Diffs
> -----
>
> src/tests/containerizer/xfs_quota_tests.cpp 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe
>
>
> Diff: https://reviews.apache.org/r/66173/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harold Dost
>
>
Re: Review Request 66173: Add test for new `disk/xfs` kill
functionality.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66173/#review201940
-----------------------------------------------------------
Ship it!
Looks good. There's a coupld of small nits that I'll fix as I commit
- James Peach
On April 20, 2018, 6:49 p.m., Harold Dost wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66173/
> -----------------------------------------------------------
>
> (Updated April 20, 2018, 6:49 p.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-6575
> https://issues.apache.org/jira/browse/MESOS-6575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-6575
>
>
> Diffs
> -----
>
> src/tests/containerizer/xfs_quota_tests.cpp 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe
>
>
> Diff: https://reviews.apache.org/r/66173/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harold Dost
>
>
Re: Review Request 66173: Add test for new `disk/xfs` kill
functionality.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66173/#review201647
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66001', '66173']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66173
Relevant logs:
- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66173/logs/mesos-tests-cmake-stdout.log):
```
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3426): warning C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500): warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501): warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479): warning C4101: 'addrstr': unreferenced local variable [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170): warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496): warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256): warning C4090: 'function': different 'const' qualifiers [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166): warning C4716: 'pthread_cond_broadcast': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): warning C4716: 'pthread_cond_wait': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
(ClCompile target) ->
d:\dcos\mesos\mesos\src\tests\slave_tests.cpp(1280): error C2039: 'switch_user': is not a member of 'mesos::internal::slave::Flags' [D:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
172 Warning(s)
1 Error(s)
Time Elapsed 00:32:13.03
```
- Mesos Reviewbot Windows
On April 20, 2018, 6:49 p.m., Harold Dost wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66173/
> -----------------------------------------------------------
>
> (Updated April 20, 2018, 6:49 p.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-6575
> https://issues.apache.org/jira/browse/MESOS-6575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-6575
>
>
> Diffs
> -----
>
> src/tests/containerizer/xfs_quota_tests.cpp 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe
>
>
> Diff: https://reviews.apache.org/r/66173/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harold Dost
>
>
Re: Review Request 66173: Add test for new `disk/xfs` kill
functionality.
Posted by Harold Dost <h....@criteo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66173/
-----------------------------------------------------------
(Updated April 20, 2018, 6:49 p.m.)
Review request for mesos and James Peach.
Changes
-------
Update based on changes.
Bugs: MESOS-6575
https://issues.apache.org/jira/browse/MESOS-6575
Repository: mesos
Description
-------
MESOS-6575
Diffs (updated)
-----
src/tests/containerizer/xfs_quota_tests.cpp 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe
Diff: https://reviews.apache.org/r/66173/diff/4/
Changes: https://reviews.apache.org/r/66173/diff/3-4/
Testing
-------
Thanks,
Harold Dost
Re: Review Request 66173: Add test for new `disk/xfs` kill
functionality.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66173/#review200931
-----------------------------------------------------------
I'm getting a test failure on `ROOT_XFS_QuotaTest.RecoverOldContainers` with these patches enabled. When we restart the agent with the XFS isolator enabled, we skip the running task because there isn't a project ID on the sandbox. Then the containerizer tells us to watch that container ID but we return a failure because we don't know anything about it. That failure causes the containerizer to kill the task. So we need to update `XfsDiskIsolatorProcess::recover` to store a placeholder to handle this case.
- James Peach
On April 4, 2018, 5:41 p.m., Harold Dost wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66173/
> -----------------------------------------------------------
>
> (Updated April 4, 2018, 5:41 p.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-6575
> https://issues.apache.org/jira/browse/MESOS-6575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-6575
>
>
> Diffs
> -----
>
> src/tests/containerizer/xfs_quota_tests.cpp 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe
>
>
> Diff: https://reviews.apache.org/r/66173/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harold Dost
>
>
Re: Review Request 66173: Add test for new `disk/xfs` kill
functionality.
Posted by Harold Dost <h....@criteo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66173/
-----------------------------------------------------------
(Updated April 4, 2018, 5:41 p.m.)
Review request for mesos and James Peach.
Bugs: MESOS-6575
https://issues.apache.org/jira/browse/MESOS-6575
Repository: mesos
Description
-------
MESOS-6575
Diffs (updated)
-----
src/tests/containerizer/xfs_quota_tests.cpp 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe
Diff: https://reviews.apache.org/r/66173/diff/3/
Changes: https://reviews.apache.org/r/66173/diff/2-3/
Testing
-------
Thanks,
Harold Dost
Re: Review Request 66173: Add test for new `disk/xfs` kill
functionality.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66173/#review199819
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66001, 66173]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 22, 2018, 2:11 p.m., Harold Dost wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66173/
> -----------------------------------------------------------
>
> (Updated March 22, 2018, 2:11 p.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-6575
> https://issues.apache.org/jira/browse/MESOS-6575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-6575
>
>
> Diffs
> -----
>
> src/tests/containerizer/xfs_quota_tests.cpp 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe
>
>
> Diff: https://reviews.apache.org/r/66173/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harold Dost
>
>
Re: Review Request 66173: Add test for new `disk/xfs` kill
functionality.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66173/#review199768
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66001', '66173']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66173
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66173/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (106 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1047 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (33 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (36 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (71 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (845 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (866 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (845 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (869 ms total)
[----------] Global test environment tear-down
[==========] 943 tests from 94 test cases ran. (449665 ms total)
[ PASSED ] 942 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 215 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66173/logs/mesos-tests-stderr.log):
```
I0322 16:04:02.558601 9632 executor.cpp:176] Received SUBSCRIBED event
I0322 16:04:02.564640 9632 executor.cpp:180] Subscribed executor on winbldsrv-02.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0322 16:04:02.564640 9632 executor.cpp:176] Received LAUNCH event
I0322 16:04:02.569643 9632 executor.cpp:648] Starting task 9da36786-a9cb-4dca-80e8-3fd70f70aeb2
I0322 16:04:02.656664 9632 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0322 16:04:02.690618 9632 executor.cpp:661] Forked command at 9704
I0322 16:04:02.726619 6328 exec.cpp:445] Executor asked to shutdown
I0322 16:04:02.727617 9636 executor.cpp:176] Received SHUTDOWN event
I0322 16:04:02.727617 9636 executor.cpp:758] Shutting down
I0322 16:04:02.727617 9636 executor.cpp:868] Sending SIGTERM to process tree at pid 9ting framework 0d1a8e2e-23df-472e-b708-a53a3214112c-0000 (default) at scheduler-b0382659-809e-40ae-b1c1-4d75be9198b4@10.3.1.5:58689
I0322 16:04:02.724619 6960 hierarchical.cpp:405] Deactivated framework 0d1a8e2e-23df-472e-b708-a53a3214112c-0000
I0322 16:04:02.724619 4372 master.cpp:10255] Updating the state of task 9da36786-a9cb-4dca-80e8-3fd70f70aeb2 of framework 0d1a8e2e-23df-472e-b708-a53a3214112c-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0322 16:04:02.724619 4552 slave.cpp:3873] Shutting down framework 0d1a8e2e-23df-472e-b708-a53a3214112c-0000
I0322 16:04:02.724619 4552 slave.cpp:6566] Shutting down executor '9da36786-a9cb-4dca-80e8-3fd70f70aeb2' of framework 0d1a8e2e-23df-472e-b708-a53a3214112c-0000 at executor(1)@10.3.1.5:58710
I0322 16:04:02.725618 4552 slave.cpp:919] Agent terminating
W0322 16:04:02.725618 4552 slave.cpp:3869] Ignoring shutdown framework 0d1a8e2e-23df-472e-b708-a53a3214112c-0000 because it is terminating
I0322 16:04:02.727617 4372 master.cpp:10354] Removing task 9da36786-a9cb-4dca-80e8-3fd70f70aeb2 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 0d1a8e2e-23df-472e-b708-a53a3214112c-0000 on agent 0d1a8e2e-23df-472e-b708-a53a3214112c-S0 at slave(412)@10.3.1.5:58689 (winbldsrv-02.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0322 16:04:02.729619 6960 containerizer.cpp:2338] Destroying container 7e5bc628-8dd2-4cc3-bbac-60611d441d5d in RUNNING state
I0322 16:04:02.729619 6960 containerizer.cpp:2952] Transitioning the state of container 7e5bc628-8dd2-4cc3-bbac-60611d441d5d from RUNNING to DESTROYING
I0322 16:04:02.730612 4372 master.cpp:1295] Agent 0d1a8e2e-23df-472e-b708-a53a3214112c-S0 at slave(412)@10.3.1.5:58689 (winbldsrv-02.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0322 16:04:02.730612 6960 launcher.cpp:156] Asked to destroy container 7e5bc628-8dd2-4cc3-bbac-60611d441d5d
I0322 16:04:02.730612 4372 master.cpp:3283] Disconnecting agent 0d1a8e2e-23df-472e-b708-a53a3214112c-S0 at slave(412)@10.3.1.5:58689 (winbldsrv-02.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0322 16:04:02.731633 8124 hierarchical.cpp:344] Removed framework 0d1a8e2e-23df-472e-b708-a53a3214112c-0000
I0322 16:04:02.731633 4372 master.cpp:3302] Deactivating agent 0d1a8e2e-23df-472e-b708-a53a3214112c-S0 at slave(412)@10.3.1.5:58689 (winbldsrv-02.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0322 16:04:02.731633 7028 hierarchical.cpp:766] Agent 0d1a8e2e-23df-472e-b708-a53a3214112c-S0 deactivated
I0322 16:04:02.842164 1732 containerizer.cpp:2791] Container 7e5bc628-8dd2-4cc3-bbac-60611d441d5d has exited
I0322 16:04:02.875162 6696 master.cpp:1137] Master terminating
I0322 16:04:02.877163 4372 hierarchical.cpp:609] Removed agent 0d1a8e2e-23df-472e-b708-a53a3214112c-S0
I0322 16:04:03.327116 5004 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 22, 2018, 7:11 a.m., Harold Dost wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66173/
> -----------------------------------------------------------
>
> (Updated March 22, 2018, 7:11 a.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-6575
> https://issues.apache.org/jira/browse/MESOS-6575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-6575
>
>
> Diffs
> -----
>
> src/tests/containerizer/xfs_quota_tests.cpp 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe
>
>
> Diff: https://reviews.apache.org/r/66173/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harold Dost
>
>
Re: Review Request 66173: Add test for new `disk/xfs` kill
functionality.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66173/#review200057
-----------------------------------------------------------
Running the test, I get this failure:
```
../../src/tests/containerizer/xfs_quota_tests.cpp:533: Failure
Failed to wait 15secs for killedStatus
```
Which indicates that the task doesn't get killed.
We should also add the following tests:
1. Verify that `flags.xfs_kill_containers` doesn't kill containers that don't violate there limits. You can do this by snsuring that you can kill the container after guaranteeing that at least one disk space usage check has elapsed (this is an argument for keeping the isolator `check` functio, since you can expect it to be called).
2. Add soft limit checks to QuotaGetSet.
3. Add soft limit checks to QuotaLimit.
src/tests/containerizer/xfs_quota_tests.cpp
Line 147 (original), 147 (patched)
<https://reviews.apache.org/r/66173/#comment280684>
Since we are now pausing the clock, we need to make sure that it is resumed so that the `losetup` exec works correctly:
```
// Make sure we resume the clock so that we can wait on the
// `losetup` process.
if (Clock::paused()) {
Clock::resume();
}
```
src/tests/containerizer/xfs_quota_tests.cpp
Lines 457 (patched)
<https://reviews.apache.org/r/66173/#comment280679>
Double newline above here.
src/tests/containerizer/xfs_quota_tests.cpp
Lines 460 (patched)
<https://reviews.apache.org/r/66173/#comment280677>
Need to update this comment for accuracy.
src/tests/containerizer/xfs_quota_tests.cpp
Lines 469 (patched)
<https://reviews.apache.org/r/66173/#comment280678>
Newline before and after this to make it stand out.
src/tests/containerizer/xfs_quota_tests.cpp
Lines 498 (patched)
<https://reviews.apache.org/r/66173/#comment280670>
We can just sleep:
```
"dd if=/dev/zero of=file bs=1048576 count=2 && sleep 100000"
```
and update the comment.
src/tests/containerizer/xfs_quota_tests.cpp
Lines 517 (patched)
<https://reviews.apache.org/r/66173/#comment280682>
So that you don't have to wait for the full check interval, you can advance the clock:
```
// Create TaskInfo ...
Clock::pause();
// Expect TASK_RUNNING ...
Clock::advance(flags.container_disk_watch_interval);
Clock::settle();
Clock::resume();
// Expect more stuff ...
```
src/tests/containerizer/xfs_quota_tests.cpp
Lines 524 (patched)
<https://reviews.apache.org/r/66173/#comment280673>
Here we should check that the resource in the limitation is what we expect:
```
EXPECT_EQ(TaskStatus::SOURCE_SLAVE, killedStatus->source());
EXPECT_EQ(
TaskStatus::REASON_CONTAINER_LIMITATION_DISK, killedStatus->reason());
ASSERT_TRUE(killedStatus->has_limitation()) << JSON::protobuf(killedStatus.get());
Resources limit = Resources(killedStatus->limitation().resources());
// Expect that we were limited on a single disk resource that represents
// the amount of disk that the task consumed.
EXPECT_EQ(1u, limit.size());
EXPECT_SOME_EQ(Megabytes(2), limit.disk());
```
src/tests/containerizer/xfs_quota_tests.cpp
Lines 528 (patched)
<https://reviews.apache.org/r/66173/#comment280680>
Double newline after here.
- James Peach
On March 22, 2018, 2:11 p.m., Harold Dost wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66173/
> -----------------------------------------------------------
>
> (Updated March 22, 2018, 2:11 p.m.)
>
>
> Review request for mesos and James Peach.
>
>
> Bugs: MESOS-6575
> https://issues.apache.org/jira/browse/MESOS-6575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-6575
>
>
> Diffs
> -----
>
> src/tests/containerizer/xfs_quota_tests.cpp 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe
>
>
> Diff: https://reviews.apache.org/r/66173/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harold Dost
>
>
Re: Review Request 66173: Add test for new `disk/xfs` kill
functionality.
Posted by Harold Dost <h....@criteo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66173/
-----------------------------------------------------------
(Updated March 22, 2018, 2:11 p.m.)
Review request for mesos and James Peach.
Bugs: MESOS-6575
https://issues.apache.org/jira/browse/MESOS-6575
Repository: mesos
Description
-------
MESOS-6575
Diffs (updated)
-----
src/tests/containerizer/xfs_quota_tests.cpp 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe
Diff: https://reviews.apache.org/r/66173/diff/2/
Changes: https://reviews.apache.org/r/66173/diff/1-2/
Testing
-------
Thanks,
Harold Dost