You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by xhochy <gi...@git.apache.org> on 2017/11/19 18:13:39 UTC
[GitHub] drill pull request #1042: DRILL-5261: Expose REST endpoint in zookeeper
GitHub user xhochy opened a pull request:
https://github.com/apache/drill/pull/1042
DRILL-5261: Expose REST endpoint in zookeeper
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xhochy/drill DRILL-5261
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1042.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1042
----
commit 2df606590158afe6cb29e9f292eb33e945c26ba0
Author: Uwe L. Korn <uw...@xhochy.com>
Date: 2017-11-19T09:36:32Z
DRILL-5261: Expose REST endpoint in zookeeper
----
---
[GitHub] drill issue #1042: DRILL-5261: Expose REST endpoint in zookeeper
Posted by xhochy <gi...@git.apache.org>.
Github user xhochy commented on the issue:
https://github.com/apache/drill/pull/1042
This still needs the protobufs to be re-compiled for C++, I would do this once someone signals me that I have taken the correct approach.
---
[GitHub] drill pull request #1042: DRILL-5261: Expose REST endpoint in zookeeper
Posted by xhochy <gi...@git.apache.org>.
Github user xhochy closed the pull request at:
https://github.com/apache/drill/pull/1042
---
[GitHub] drill issue #1042: DRILL-5261: Expose REST endpoint in zookeeper
Posted by kkhatua <gi...@git.apache.org>.
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1042
@paul-rogers , since you've responded to the original JIRA, perhaps you can review this for @xhochy
---
[GitHub] drill issue #1042: DRILL-5261: Expose REST endpoint in zookeeper
Posted by kkhatua <gi...@git.apache.org>.
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1042
@xhochy I recently had a PR #1203 for DRILL-6289 and realized your PR's solution was a subset of that. I've already incorporated changes to the C++ client's protobuf as well. If it addresses the requirements you had for this JIRA, can you close the PR? If there is something missing, feel free to submit a new PR with the missing feature.
---
[GitHub] drill issue #1042: DRILL-5261: Expose REST endpoint in zookeeper
Posted by xhochy <gi...@git.apache.org>.
Github user xhochy commented on the issue:
https://github.com/apache/drill/pull/1042
@kkhatua Thanks, I'll have a look at that PR.
---