You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2010/07/04 17:44:45 UTC
svn commit: r960348 - in /tomcat/trunk:
java/org/apache/tomcat/util/net/JIoEndpoint.java
test/org/apache/catalina/core/TestAsyncListener.java
webapps/docs/changelog.xml
Author: markt
Date: Sun Jul 4 15:44:45 2010
New Revision: 960348
URL: http://svn.apache.org/viewvc?rev=960348&view=rev
Log:
Revert r958362, r960083, r958406, r960069. r958362 broke the TCK tests and the other commits were sufficiently tightly coupled to it that it was easier to revert all of them than try to unpick them.
Removed:
tomcat/trunk/test/org/apache/catalina/core/TestAsyncListener.java
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java?rev=960348&r1=960347&r2=960348&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java Sun Jul 4 15:44:45 2010
@@ -399,11 +399,6 @@ public class JIoEndpoint extends Abstrac
acceptorThread.setDaemon(getDaemon());
acceptorThread.start();
}
-
- // Start async timeout thread
- Thread timeoutThread = new Thread(new AsyncTimeout(),getName() + "-AsyncTimeout");
- timeoutThread.setDaemon(true);
- timeoutThread.start();
}
}
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=960348&r1=960347&r2=960348&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Sun Jul 4 15:44:45 2010
@@ -98,14 +98,6 @@
</add>
</changelog>
</subsection>
- <subsection name="Coyote">
- <changelog>
- <fix>
- Start JioEndpoint timeout thread, to inform AsyncListner as async timeout is detected
- and application thread doesn't finished the request. (pero)
- </fix>
- </changelog>
- </subsection>
<subsection name="Jasper">
<changelog>
<update>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r960348 - in /tomcat/trunk: java/org/apache/tomcat/util/net/JIoEndpoint.java test/org/apache/catalina/core/TestAsyncListener.java webapps/docs/changelog.xml
Posted by Peter Roßbach <pr...@objektpark.de>.
Hi Mark,
why you remove and doesn't correct the TestCases?
Please, explain how a AsyncListner can receive onTimeout ?
Peter
Am 04.07.2010 um 17:44 schrieb markt@apache.org:
> Author: markt
> Date: Sun Jul 4 15:44:45 2010
> New Revision: 960348
>
> URL: http://svn.apache.org/viewvc?rev=960348&view=rev
> Log:
> Revert r958362, r960083, r958406, r960069. r958362 broke the TCK
> tests and the other commits were sufficiently tightly coupled to it
> that it was easier to revert all of them than try to unpick them.
>
> Removed:
> tomcat/trunk/test/org/apache/catalina/core/TestAsyncListener.java
> Modified:
> tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
> tomcat/trunk/webapps/docs/changelog.xml
>
> Modified: tomcat/trunk/java/org/apache/tomcat/util/net/
> JIoEndpoint.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java?rev=960348&r1=960347&r2=960348&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
> (original)
> +++ tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
> Sun Jul 4 15:44:45 2010
> @@ -399,11 +399,6 @@ public class JIoEndpoint extends Abstrac
> acceptorThread.setDaemon(getDaemon());
> acceptorThread.start();
> }
> -
> - // Start async timeout thread
> - Thread timeoutThread = new Thread(new
> AsyncTimeout(),getName() + "-AsyncTimeout");
> - timeoutThread.setDaemon(true);
> - timeoutThread.start();
> }
> }
>
>
> Modified: tomcat/trunk/webapps/docs/changelog.xml
> URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=960348&r1=960347&r2=960348&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- tomcat/trunk/webapps/docs/changelog.xml (original)
> +++ tomcat/trunk/webapps/docs/changelog.xml Sun Jul 4 15:44:45 2010
> @@ -98,14 +98,6 @@
> </add>
> </changelog>
> </subsection>
> - <subsection name="Coyote">
> - <changelog>
> - <fix>
> - Start JioEndpoint timeout thread, to inform AsyncListner as
> async timeout is detected
> - and application thread doesn't finished the request. (pero)
> - </fix>
> - </changelog>
> - </subsection>
> <subsection name="Jasper">
> <changelog>
> <update>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org