You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2010/10/13 22:06:41 UTC

svn commit: r1022277 - /commons/proper/pool/trunk/pom.xml

Author: ggregory
Date: Wed Oct 13 20:06:41 2010
New Revision: 1022277

URL: http://svn.apache.org/viewvc?rev=1022277&view=rev
Log:
maven-checkstyle-plugin 2.1 -> 2.3 (2.4 fails with "Embedded error: Error rendering Maven report: Failed during checkstyle configuration TreeWalker is not allowed as a parent of Header")

Modified:
    commons/proper/pool/trunk/pom.xml

Modified: commons/proper/pool/trunk/pom.xml
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/pom.xml?rev=1022277&r1=1022276&r2=1022277&view=diff
==============================================================================
--- commons/proper/pool/trunk/pom.xml (original)
+++ commons/proper/pool/trunk/pom.xml Wed Oct 13 20:06:41 2010
@@ -246,7 +246,7 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-checkstyle-plugin</artifactId>
-          <version>2.1</version>
+          <version>2.3</version>
           <configuration>
             <configLocation>${basedir}/checkstyle.xml</configLocation>
             <enableRulesSummary>false</enableRulesSummary>



RE: svn commit: r1022277 - /commons/proper/pool/trunk/pom.xml

Posted by Gary Gregory <GG...@seagullsoftware.com>.
> -----Original Message-----
> From: Niall Pemberton [mailto:niall.pemberton@gmail.com]
> Sent: Wednesday, October 13, 2010 13:13
> To: dev@commons.apache.org
> Subject: Re: svn commit: r1022277 - /commons/proper/pool/trunk/pom.xml
> 
> Would be better to upgrade to the more recent checkstyle plugin (2.6)
> - see details in the commit log:
> 
> http://svn.apache.org/viewvc?view=revision&revision=1005273
> 

Right, when I tried 2.6 it blew up with the same error as when I tried to move from 2.3 to 2.4. I suppose the checktyle config file needs updating.

Gary 


> Niall
> 
> On Wed, Oct 13, 2010 at 9:06 PM,  <gg...@apache.org> wrote:
> > Author: ggregory
> > Date: Wed Oct 13 20:06:41 2010
> > New Revision: 1022277
> >
> > URL: http://svn.apache.org/viewvc?rev=1022277&view=rev
> > Log:
> > maven-checkstyle-plugin 2.1 -> 2.3 (2.4 fails with "Embedded error: Error
> rendering Maven report: Failed during checkstyle configuration TreeWalker is
> not allowed as a parent of Header")
> >
> > Modified:
> >    commons/proper/pool/trunk/pom.xml
> >
> > Modified: commons/proper/pool/trunk/pom.xml
> > URL:
> http://svn.apache.org/viewvc/commons/proper/pool/trunk/pom.xml?rev=1022277&r1=
> 1022276&r2=1022277&view=diff
> >
> ==============================================================================
> > --- commons/proper/pool/trunk/pom.xml (original)
> > +++ commons/proper/pool/trunk/pom.xml Wed Oct 13 20:06:41 2010
> > @@ -246,7 +246,7 @@
> >         <plugin>
> >           <groupId>org.apache.maven.plugins</groupId>
> >           <artifactId>maven-checkstyle-plugin</artifactId>
> > -          <version>2.1</version>
> > +          <version>2.3</version>
> >           <configuration>
> >             <configLocation>${basedir}/checkstyle.xml</configLocation>
> >             <enableRulesSummary>false</enableRulesSummary>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


RE: svn commit: r1022277 - /commons/proper/pool/trunk/pom.xml

Posted by Gary Gregory <GG...@seagullsoftware.com>.
POM and checkstyle.xml are now on the 2.6 Maven plugin.

Gary

> -----Original Message-----
> From: Niall Pemberton [mailto:niall.pemberton@gmail.com]
> Sent: Wednesday, October 13, 2010 13:39
> To: Commons Developers List
> Subject: Re: svn commit: r1022277 - /commons/proper/pool/trunk/pom.xml
> 
> On Wed, Oct 13, 2010 at 9:35 PM, Gary Gregory
> <GG...@seagullsoftware.com> wrote:
> >> -----Original Message-----
> >> From: Dennis Lundberg [mailto:dennisl@apache.org]
> >> Sent: Wednesday, October 13, 2010 13:28
> >> To: Commons Developers List
> >> Subject: Re: svn commit: r1022277 - /commons/proper/pool/trunk/pom.xml
> >>
> >> Checkstyle plugin 2.4+ uses Checkstyle 5, which has a slightly altered
> >> configuration format. If you upgrade to 2.4+ you also need to change the
> >> Checkstyle configuration file. Let me know if you need details, and I'll
> >> dig them up for you.
> >
> > Please dig ;)
> 
> I gave you details already - just follow the link in my previous
> message and read the commit log - it also has link to checkstyle page
> 
> Niall
> 
> 
> > Gary
> >
> >>
> >> On 2010-10-13 22:13, Niall Pemberton wrote:
> >> > Would be better to upgrade to the more recent checkstyle plugin (2.6)
> >> > - see details in the commit log:
> >> >
> >> > http://svn.apache.org/viewvc?view=revision&revision=1005273
> >> >
> >> > Niall
> >> >
> >> > On Wed, Oct 13, 2010 at 9:06 PM,  <gg...@apache.org> wrote:
> >> >> Author: ggregory
> >> >> Date: Wed Oct 13 20:06:41 2010
> >> >> New Revision: 1022277
> >> >>
> >> >> URL: http://svn.apache.org/viewvc?rev=1022277&view=rev
> >> >> Log:
> >> >> maven-checkstyle-plugin 2.1 -> 2.3 (2.4 fails with "Embedded error:
> Error
> >> rendering Maven report: Failed during checkstyle configuration TreeWalker
> is
> >> not allowed as a parent of Header")
> >> >>
> >> >> Modified:
> >> >>    commons/proper/pool/trunk/pom.xml
> >> >>
> >> >> Modified: commons/proper/pool/trunk/pom.xml
> >> >> URL:
> >>
> http://svn.apache.org/viewvc/commons/proper/pool/trunk/pom.xml?rev=1022277&r1=
> >> 1022276&r2=1022277&view=diff
> >> >>
> >>
> ==============================================================================
> >> >> --- commons/proper/pool/trunk/pom.xml (original)
> >> >> +++ commons/proper/pool/trunk/pom.xml Wed Oct 13 20:06:41 2010
> >> >> @@ -246,7 +246,7 @@
> >> >>         <plugin>
> >> >>           <groupId>org.apache.maven.plugins</groupId>
> >> >>           <artifactId>maven-checkstyle-plugin</artifactId>
> >> >> -          <version>2.1</version>
> >> >> +          <version>2.3</version>
> >> >>           <configuration>
> >> >>             <configLocation>${basedir}/checkstyle.xml</configLocation>
> >> >>             <enableRulesSummary>false</enableRulesSummary>
> >> >
> >> > ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> > For additional commands, e-mail: dev-help@commons.apache.org
> >> >
> >> >
> >>
> >>
> >> --
> >> Dennis Lundberg
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1022277 - /commons/proper/pool/trunk/pom.xml

Posted by Niall Pemberton <ni...@gmail.com>.
On Wed, Oct 13, 2010 at 9:35 PM, Gary Gregory
<GG...@seagullsoftware.com> wrote:
>> -----Original Message-----
>> From: Dennis Lundberg [mailto:dennisl@apache.org]
>> Sent: Wednesday, October 13, 2010 13:28
>> To: Commons Developers List
>> Subject: Re: svn commit: r1022277 - /commons/proper/pool/trunk/pom.xml
>>
>> Checkstyle plugin 2.4+ uses Checkstyle 5, which has a slightly altered
>> configuration format. If you upgrade to 2.4+ you also need to change the
>> Checkstyle configuration file. Let me know if you need details, and I'll
>> dig them up for you.
>
> Please dig ;)

I gave you details already - just follow the link in my previous
message and read the commit log - it also has link to checkstyle page

Niall


> Gary
>
>>
>> On 2010-10-13 22:13, Niall Pemberton wrote:
>> > Would be better to upgrade to the more recent checkstyle plugin (2.6)
>> > - see details in the commit log:
>> >
>> > http://svn.apache.org/viewvc?view=revision&revision=1005273
>> >
>> > Niall
>> >
>> > On Wed, Oct 13, 2010 at 9:06 PM,  <gg...@apache.org> wrote:
>> >> Author: ggregory
>> >> Date: Wed Oct 13 20:06:41 2010
>> >> New Revision: 1022277
>> >>
>> >> URL: http://svn.apache.org/viewvc?rev=1022277&view=rev
>> >> Log:
>> >> maven-checkstyle-plugin 2.1 -> 2.3 (2.4 fails with "Embedded error: Error
>> rendering Maven report: Failed during checkstyle configuration TreeWalker is
>> not allowed as a parent of Header")
>> >>
>> >> Modified:
>> >>    commons/proper/pool/trunk/pom.xml
>> >>
>> >> Modified: commons/proper/pool/trunk/pom.xml
>> >> URL:
>> http://svn.apache.org/viewvc/commons/proper/pool/trunk/pom.xml?rev=1022277&r1=
>> 1022276&r2=1022277&view=diff
>> >>
>> ==============================================================================
>> >> --- commons/proper/pool/trunk/pom.xml (original)
>> >> +++ commons/proper/pool/trunk/pom.xml Wed Oct 13 20:06:41 2010
>> >> @@ -246,7 +246,7 @@
>> >>         <plugin>
>> >>           <groupId>org.apache.maven.plugins</groupId>
>> >>           <artifactId>maven-checkstyle-plugin</artifactId>
>> >> -          <version>2.1</version>
>> >> +          <version>2.3</version>
>> >>           <configuration>
>> >>             <configLocation>${basedir}/checkstyle.xml</configLocation>
>> >>             <enableRulesSummary>false</enableRulesSummary>
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> > For additional commands, e-mail: dev-help@commons.apache.org
>> >
>> >
>>
>>
>> --
>> Dennis Lundberg
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


RE: svn commit: r1022277 - /commons/proper/pool/trunk/pom.xml

Posted by Gary Gregory <GG...@seagullsoftware.com>.
> -----Original Message-----
> From: Dennis Lundberg [mailto:dennisl@apache.org]
> Sent: Wednesday, October 13, 2010 13:28
> To: Commons Developers List
> Subject: Re: svn commit: r1022277 - /commons/proper/pool/trunk/pom.xml
> 
> Checkstyle plugin 2.4+ uses Checkstyle 5, which has a slightly altered
> configuration format. If you upgrade to 2.4+ you also need to change the
> Checkstyle configuration file. Let me know if you need details, and I'll
> dig them up for you.

Please dig ;)

Gary

> 
> On 2010-10-13 22:13, Niall Pemberton wrote:
> > Would be better to upgrade to the more recent checkstyle plugin (2.6)
> > - see details in the commit log:
> >
> > http://svn.apache.org/viewvc?view=revision&revision=1005273
> >
> > Niall
> >
> > On Wed, Oct 13, 2010 at 9:06 PM,  <gg...@apache.org> wrote:
> >> Author: ggregory
> >> Date: Wed Oct 13 20:06:41 2010
> >> New Revision: 1022277
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1022277&view=rev
> >> Log:
> >> maven-checkstyle-plugin 2.1 -> 2.3 (2.4 fails with "Embedded error: Error
> rendering Maven report: Failed during checkstyle configuration TreeWalker is
> not allowed as a parent of Header")
> >>
> >> Modified:
> >>    commons/proper/pool/trunk/pom.xml
> >>
> >> Modified: commons/proper/pool/trunk/pom.xml
> >> URL:
> http://svn.apache.org/viewvc/commons/proper/pool/trunk/pom.xml?rev=1022277&r1=
> 1022276&r2=1022277&view=diff
> >>
> ==============================================================================
> >> --- commons/proper/pool/trunk/pom.xml (original)
> >> +++ commons/proper/pool/trunk/pom.xml Wed Oct 13 20:06:41 2010
> >> @@ -246,7 +246,7 @@
> >>         <plugin>
> >>           <groupId>org.apache.maven.plugins</groupId>
> >>           <artifactId>maven-checkstyle-plugin</artifactId>
> >> -          <version>2.1</version>
> >> +          <version>2.3</version>
> >>           <configuration>
> >>             <configLocation>${basedir}/checkstyle.xml</configLocation>
> >>             <enableRulesSummary>false</enableRulesSummary>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
> 
> 
> --
> Dennis Lundberg
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1022277 - /commons/proper/pool/trunk/pom.xml

Posted by Dennis Lundberg <de...@apache.org>.
Checkstyle plugin 2.4+ uses Checkstyle 5, which has a slightly altered
configuration format. If you upgrade to 2.4+ you also need to change the
Checkstyle configuration file. Let me know if you need details, and I'll
dig them up for you.

On 2010-10-13 22:13, Niall Pemberton wrote:
> Would be better to upgrade to the more recent checkstyle plugin (2.6)
> - see details in the commit log:
> 
> http://svn.apache.org/viewvc?view=revision&revision=1005273
> 
> Niall
> 
> On Wed, Oct 13, 2010 at 9:06 PM,  <gg...@apache.org> wrote:
>> Author: ggregory
>> Date: Wed Oct 13 20:06:41 2010
>> New Revision: 1022277
>>
>> URL: http://svn.apache.org/viewvc?rev=1022277&view=rev
>> Log:
>> maven-checkstyle-plugin 2.1 -> 2.3 (2.4 fails with "Embedded error: Error rendering Maven report: Failed during checkstyle configuration TreeWalker is not allowed as a parent of Header")
>>
>> Modified:
>>    commons/proper/pool/trunk/pom.xml
>>
>> Modified: commons/proper/pool/trunk/pom.xml
>> URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/pom.xml?rev=1022277&r1=1022276&r2=1022277&view=diff
>> ==============================================================================
>> --- commons/proper/pool/trunk/pom.xml (original)
>> +++ commons/proper/pool/trunk/pom.xml Wed Oct 13 20:06:41 2010
>> @@ -246,7 +246,7 @@
>>         <plugin>
>>           <groupId>org.apache.maven.plugins</groupId>
>>           <artifactId>maven-checkstyle-plugin</artifactId>
>> -          <version>2.1</version>
>> +          <version>2.3</version>
>>           <configuration>
>>             <configLocation>${basedir}/checkstyle.xml</configLocation>
>>             <enableRulesSummary>false</enableRulesSummary>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 
> 


-- 
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1022277 - /commons/proper/pool/trunk/pom.xml

Posted by Niall Pemberton <ni...@gmail.com>.
Would be better to upgrade to the more recent checkstyle plugin (2.6)
- see details in the commit log:

http://svn.apache.org/viewvc?view=revision&revision=1005273

Niall

On Wed, Oct 13, 2010 at 9:06 PM,  <gg...@apache.org> wrote:
> Author: ggregory
> Date: Wed Oct 13 20:06:41 2010
> New Revision: 1022277
>
> URL: http://svn.apache.org/viewvc?rev=1022277&view=rev
> Log:
> maven-checkstyle-plugin 2.1 -> 2.3 (2.4 fails with "Embedded error: Error rendering Maven report: Failed during checkstyle configuration TreeWalker is not allowed as a parent of Header")
>
> Modified:
>    commons/proper/pool/trunk/pom.xml
>
> Modified: commons/proper/pool/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/pom.xml?rev=1022277&r1=1022276&r2=1022277&view=diff
> ==============================================================================
> --- commons/proper/pool/trunk/pom.xml (original)
> +++ commons/proper/pool/trunk/pom.xml Wed Oct 13 20:06:41 2010
> @@ -246,7 +246,7 @@
>         <plugin>
>           <groupId>org.apache.maven.plugins</groupId>
>           <artifactId>maven-checkstyle-plugin</artifactId>
> -          <version>2.1</version>
> +          <version>2.3</version>
>           <configuration>
>             <configLocation>${basedir}/checkstyle.xml</configLocation>
>             <enableRulesSummary>false</enableRulesSummary>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org