You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/05/15 02:49:34 UTC

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2635: [GOBBLIN-771] add a few metrics for gobblin service

sv2000 commented on a change in pull request #2635: [GOBBLIN-771] add  a few metrics for gobblin service
URL: https://github.com/apache/incubator-gobblin/pull/2635#discussion_r284069171
 
 

 ##########
 File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_catalog/FlowCatalog.java
 ##########
 @@ -98,6 +102,8 @@ public FlowCatalog(Config config, Optional<Logger> log, Optional<MetricContext>
       MetricContext realParentCtx =
           parentMetricContext.or(Instrumented.getMetricContext(new org.apache.gobblin.configuration.State(), getClass()));
       this.metricContext = realParentCtx.childBuilder(FlowCatalog.class.getSimpleName()).build();
+      putMeter = metricContext.contextAwareMeter("testGaas");
 
 Review comment:
   I don't think you are intending  to use "testGaas" as the meter name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services