Re: svn commit: r472883 - /xmlgraphics/batik/trunk/sources/org/apache/batik/anim/timing/TimedElement.java

[Cameron McCormack <ca...@mcc.id.au>]

dvholten@apache.org:
> -        for (int i = index; index >= 0; index--) {
> -            InstanceTime it = (InstanceTime) instanceTimes.get(i);
> +        for (int i = index; index >= 0; index--) {                       // todo cam, please check this
> +            InstanceTime it = (InstanceTime) instanceTimes.get(i);       // todo everything ok with i <-> index?? 
…
> -        for (int i = index + 1; index < len; i++) {
> +        for (int i = index + 1; index < len; i++) {      // todo cam, please check this

Yep these two are bugs.

> +        } else if (time == Float.POSITIVE_INFINITY) {  // should also test for NEGATIVE_INFINITY?

I never use Float.NEGATIVE_INFINITY for time values: POSITIVE_INFINITY
and NaN are the only two special values (for indefinite and unresolved
times).

-- 
Cameron McCormack, http://mcc.id.au/
	xmpp:heycam@jabber.org  ▪  ICQ 26955922  ▪  MSN cam@mcc.id.au

---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org