You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by qmlmoon <gi...@git.apache.org> on 2015/02/19 17:38:45 UTC
[GitHub] flink pull request: [FLINK-1582][streaming]Allow SocketStream to r...
GitHub user qmlmoon opened a pull request:
https://github.com/apache/flink/pull/424
[FLINK-1582][streaming]Allow SocketStream to reconnect when socket closes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/qmlmoon/incubator-flink socket
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/424.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #424
----
commit fb9549ed3e56705cc01911dec80813c7db6452fa
Author: mingliang <qm...@gmail.com>
Date: 2015-02-19T15:53:32Z
[FLINK-1582][streaming]Allow SocketStream to reconnect when socket closes.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1582][streaming]Allow SocketStream to r...
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/424#issuecomment-75153547
Thanks for quickly picking out the issue. Looks good to me I might modify it to exponentially increase wait time until a limit instead of constant 5 seconds. What do you think, which would you prefer as a user?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1582][streaming]Allow SocketStream to r...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/424
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1582][streaming]Allow SocketStream to r...
Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/424#issuecomment-75186840
+1 for exponentially increasing wait time
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1582][streaming]Allow SocketStream to r...
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/424#issuecomment-75330500
I was thinking as high as a minute to have as a limit. But after reconsidering it I am for your argument, trying to establish the connection every couple of seconds should not be a big overhead, so my whole idea might be an overkill. Let us have your version for now and generalize it on request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1582][streaming]Allow SocketStream to r...
Posted by qmlmoon <gi...@git.apache.org>.
Github user qmlmoon commented on the pull request:
https://github.com/apache/flink/pull/424#issuecomment-75197699
As a user I would expect the system could carry on quickly after server socket is reinitiated. A large limit of exponentially increase may lead to potential long wait and a small one makes it similar to constant way. what number do you suggest?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---