You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@ip-10-146-233-104.ec2.internal> on 2016/01/27 19:02:37 UTC

[kudu-CR] KUDU-1313. Fix client_samples-test to allow parallel runs on the same machine

Hello Jean-Daniel Cryans, Adar Dembo,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/1919

to review the following change.

Change subject: KUDU-1313. Fix client_samples-test to allow parallel runs on the same machine
......................................................................

KUDU-1313. Fix client_samples-test to allow parallel runs on the same machine

This switches the shell script to use the same pid-based trickery to
generate a unique localhost IP address that the other tests use.

Tested manually by running 'ctest -R samples &' four times in quick
succession. Without the patch, 3/4 of the runs failed. With the patch,
they all succeeded.

Change-Id: Iae90683a1c2264501a5740848b524841500e261e
---
M src/kudu/client/client_samples-test.sh
M src/kudu/client/samples/sample.cc
2 files changed, 26 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/1919/1
-- 
To view, visit http://gerrit.cloudera.org:8080/1919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae90683a1c2264501a5740848b524841500e261e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans