You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2024/03/25 16:15:03 UTC
[PR] Removed elasticity comment to do in ExternalCompaction_2_IT [accumulo]
dlmarion opened a new pull request, #4416:
URL: https://github.com/apache/accumulo/pull/4416
The comment said that the operation id needed to be set when deleting the tablets. This is now done in ReserveTablets.isReady.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed elasticity comment to do in ExternalCompaction_2_IT [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #4416:
URL: https://github.com/apache/accumulo/pull/4416#discussion_r1549759798
##########
test/src/main/java/org/apache/accumulo/test/compaction/ExternalCompaction_2_IT.java:
##########
@@ -238,9 +238,6 @@ public void testDeleteTableCancelsUserExternalCompaction() throws Exception {
confirmCompactionCompleted(getCluster().getServerContext(), ecids,
TCompactionState.CANCELLED);
- // ELASTICITY_TODO make delete table fate op get operation ids before deleting
- // there should be no metadata for the table, check to see if the compaction wrote anything
- // after table delete
try (var scanner = client.createScanner(AccumuloTable.METADATA.tableName())) {
Review Comment:
Could take a bit of the comment that describes the purpose of the scan
```suggestion
// Ensure compaction did not write anything to metadata table after delete table
try (var scanner = client.createScanner(AccumuloTable.METADATA.tableName())) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed elasticity comment to do in ExternalCompaction_2_IT [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion merged PR #4416:
URL: https://github.com/apache/accumulo/pull/4416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org