You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2013/05/15 20:39:06 UTC
[Bug 54977] New: As a Jmeter user, I want to choose the client alias
for the cert key in JsseSslManager such that Mutual SSL auth testing can be
made more flexible
https://issues.apache.org/bugzilla/show_bug.cgi?id=54977
Bug ID: 54977
Summary: As a Jmeter user, I want to choose the client alias
for the cert key in JsseSslManager such that Mutual
SSL auth testing can be made more flexible
Product: JMeter
Version: 2.9
Hardware: Macintosh
Status: NEW
Severity: enhancement
Priority: P2
Component: Main
Assignee: issues@jmeter.apache.org
Reporter: chrisryp@gmail.com
Classification: Unclassified
Currently, in JsseSSLManager the alias selection is managed soley by the
incrementing key index value. The user cannot override the selection of a
specific client alias for a thread in ThreadGroup. This makes testing Mutual
SSL auth impossible to do if each thread must be assigned a specific client
alias. One potential approach is to handle this is to allow the user to define
a hint variable in the thread and parse that in
WrappedX509KeyManager.chooseClientAlias() as such:
> diff JsseSSLManager.java JsseSSLManager.java.proposed
42a43
> import org.apache.jmeter.threads.JMeterContextService;
397c398,407
< String alias = this.store.getAlias();
---
>
> // Give the user a choice to select the alias by reading an alias hint from
> // a thread local variable
> String aliasHint =
> JMeterContextService.getContext().getVariables().
> get("jmeter.keystore.alias.hint");
> String alias = aliasHint;
> if (alias == null) {
> alias = this.store.getAlias();
> }
A better, long term approach is to improve KeyStoreConfiguration to allow a
thread local variable to specify the alias for the cert key but this requires
the SSLManager to not be a singleton or to process thread local variables as
above.
Note that chooseClientAlias() has a comment currently that suggests allowing
the user to choose the client alias is already on the TODO list:
TODO? - does not actually allow the user to choose an alias at present
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 54977] Ability to choose the client alias for the cert key in
JsseSslManager such that Mutual SSL auth testing can be made more flexible
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54977
--- Comment #3 from UbikLoadPack support <su...@ubikloadpack.com> ---
Created attachment 31136
--> https://issues.apache.org/bugzilla/attachment.cgi?id=31136&action=edit
Plan showing how to use feature
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 54977] Ability to choose the client alias for the cert key in
JsseSslManager such that Mutual SSL auth testing can be made more flexible
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54977
UbikLoadPack support <su...@ubikloadpack.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from UbikLoadPack support <su...@ubikloadpack.com> ---
Date: Thu Dec 19 20:56:21 2013
New Revision: 1552423
URL: http://svn.apache.org/r1552423
Log:
Bug 54977 - Ability to choose the client alias for the cert key in
JsseSslManager such that Mutual SSL auth testing can be made more flexible
Bugzilla Id: 54977
Modified:
jmeter/trunk/docs/images/screenshots/keystore_config.png
jmeter/trunk/src/components/org/apache/jmeter/config/KeystoreConfig.java
jmeter/trunk/src/components/org/apache/jmeter/config/KeystoreConfigBeanInfo.java
jmeter/trunk/src/components/org/apache/jmeter/config/KeystoreConfigResources.properties
jmeter/trunk/src/components/org/apache/jmeter/config/KeystoreConfigResources_fr.properties
jmeter/trunk/src/core/org/apache/jmeter/util/JsseSSLManager.java
jmeter/trunk/src/core/org/apache/jmeter/util/SSLManager.java
jmeter/trunk/src/core/org/apache/jmeter/util/keystore/JmeterKeyStore.java
jmeter/trunk/xdocs/changes.xml
jmeter/trunk/xdocs/images/screenshots/keystore_config.png
jmeter/trunk/xdocs/usermanual/component_reference.xml
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 54977] Ability to choose the client alias for the cert key in
JsseSslManager such that Mutual SSL auth testing can be made more flexible
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54977
--- Comment #2 from UbikLoadPack support <su...@ubikloadpack.com> ---
Created attachment 31135
--> https://issues.apache.org/bugzilla/attachment.cgi?id=31135&action=edit
Screenshot showing KeystoreConfig
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 54977] Ability to choose the client alias for the cert key in
JsseSslManager such that Mutual SSL auth testing can be made more flexible
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54977
UbikLoadPack support <su...@ubikloadpack.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |support@ubikloadpack.com
--- Comment #1 from UbikLoadPack support <su...@ubikloadpack.com> ---
Created attachment 31134
--> https://issues.apache.org/bugzilla/attachment.cgi?id=31134&action=edit
Patch proposal that implements this feature
Hello,
Please find attached a patch that implements the described feature.
Note by the way it fixes the following:
- When certificates are not found, IllegalArgumentException or
IllegalStateException are thrown making debug much easier
- SSLManager#getKeyStore has been synchronized to avoid synchronization issues
if Preload is set to false and performance issues due to as many loads as there
are threads in worst case
As always, we grant full rights to use, modify, do anything project wants to do
with classes as per our signed CLA.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 54977] Ability to choose the client alias for the cert key in
JsseSslManager such that Mutual SSL auth testing can be made more flexible
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54977
UbikLoadPack support <su...@ubikloadpack.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Hardware|Macintosh |All
Summary|As a Jmeter user, I want to |Ability to choose the
|choose the client alias for |client alias for the cert
|the cert key in |key in JsseSslManager such
|JsseSslManager such that |that Mutual SSL auth
|Mutual SSL auth testing can |testing can be made more
|be made more flexible |flexible
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 54977] Ability to choose the client alias for the cert key in
JsseSslManager such that Mutual SSL auth testing can be made more flexible
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54977
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |p.mouawad@ubik-ingenierie.c
| |om
--- Comment #5 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Thanks for patch , applied with minor changes on message labels.
PS : Next time, wait for a JMeter commiter to put the commit mail message and
mark bug as resolved.
--
You are receiving this mail because:
You are the assignee for the bug.