[jira] [Commented] (FLINK-7404) Table API batch join code-gen's equi-join conditions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120102#comment-16120102 ] 

ASF GitHub Bot commented on FLINK-7404:
---------------------------------------

GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/4507

    [FLINK-7404] [table] Generate code for non-equi join conditions only.

    ## What is the purpose of the change
    
    Generate code only for non-equi join conditions for Table API / SQL batch joins. 
    Equi join conditions are validated by the DataSet API.
    
    ## Brief change log
    
    - remove equi-join conditions before code generation
    
    ## Verifying this change
    
    - all existing tests pass.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): *no*
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: *no*
      - The serializers: *no*
      - The runtime per-record code paths (performance sensitive): *yes*
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: *no*
    
    ## Documentation
    
    - internal change only. No documentation required.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink tableJoinCondition

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4507.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4507
    
----
commit e1871c4f2e5ee9cc42831469fe6580d25d32361c
Author: Fabian Hueske <fh...@apache.org>
Date:   2017-08-09T15:41:10Z

    [FLINK-7404] [table] Generate code for non-equi join conditions only.

----


> Table API batch join code-gen's equi-join conditions
> ----------------------------------------------------
>
>                 Key: FLINK-7404
>                 URL: https://issues.apache.org/jira/browse/FLINK-7404
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.4.0, 1.3.2
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>
> {{DataSetJoin}} generates code to evaluate equi-join conditions. However, these conditions are already evaluated by the DataSet join.
> Hence, the generated conditions result in unnecessary overhead.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)