You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "wangyum (via GitHub)" <gi...@apache.org> on 2023/02/03 09:21:31 UTC
[GitHub] [spark] wangyum opened a new pull request, #39876: [SPARK-42333][SQL] Change log level to debug when fetching result set from SparkExecuteStatementOperation
wangyum opened a new pull request, #39876:
URL: https://github.com/apache/spark/pull/39876
### What changes were proposed in this pull request?
Change log level from info to debug when fetching result set from `SparkExecuteStatementOperation`.
### Why are the changes needed?
Avoid generating too many logs:
<img width="1230" alt="image" src="https://user-images.githubusercontent.com/5399861/216561187-6ad00458-d196-4f3a-a314-b2f309aec482.png">
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #39876: [SPARK-42333][SQL] Change log level to debug when fetching result set from SparkExecuteStatementOperation
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #39876:
URL: https://github.com/apache/spark/pull/39876#discussion_r1096104505
##########
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala:
##########
@@ -96,7 +96,7 @@ private[hive] class SparkExecuteStatementOperation(
private def getNextRowSetInternal(
order: FetchOrientation,
maxRowsL: Long): TRowSet = withLocalProperties {
- log.info(s"Received getNextRowSet request order=${order} and maxRowsL=${maxRowsL} " +
+ log.debug(s"Received getNextRowSet request order=${order} and maxRowsL=${maxRowsL} " +
Review Comment:
hmm... @wangyum @dongjoon-hyun
should we change to use
```
if (log.isDebugEnabled) {
log.debug( ... )
}
```
or `logDebug(...)` here?
Using `log.debug` directly may not avoid the cost of string splicing ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #39876: [SPARK-42333][SQL] Change log level to debug when fetching result set from SparkExecuteStatementOperation
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #39876: [SPARK-42333][SQL] Change log level to debug when fetching result set from SparkExecuteStatementOperation
URL: https://github.com/apache/spark/pull/39876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #39876: [SPARK-42333][SQL] Change log level to debug when fetching result set from SparkExecuteStatementOperation
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #39876:
URL: https://github.com/apache/spark/pull/39876#discussion_r1096104505
##########
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala:
##########
@@ -96,7 +96,7 @@ private[hive] class SparkExecuteStatementOperation(
private def getNextRowSetInternal(
order: FetchOrientation,
maxRowsL: Long): TRowSet = withLocalProperties {
- log.info(s"Received getNextRowSet request order=${order} and maxRowsL=${maxRowsL} " +
+ log.debug(s"Received getNextRowSet request order=${order} and maxRowsL=${maxRowsL} " +
Review Comment:
hmm... @wangyum @dongjoon-hyun
should we change to use
```
if (log.isDebugEnabled) {
log.debug( ... )
}
```
or `logDebug(...)` here?
Using `log.debug` may not avoid the cost of string splicing ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39876: [SPARK-42333][SQL] Change log level to debug when fetching result set from SparkExecuteStatementOperation
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #39876:
URL: https://github.com/apache/spark/pull/39876#discussion_r1096151254
##########
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala:
##########
@@ -96,7 +96,7 @@ private[hive] class SparkExecuteStatementOperation(
private def getNextRowSetInternal(
order: FetchOrientation,
maxRowsL: Long): TRowSet = withLocalProperties {
- log.info(s"Received getNextRowSet request order=${order} and maxRowsL=${maxRowsL} " +
+ log.debug(s"Received getNextRowSet request order=${order} and maxRowsL=${maxRowsL} " +
Review Comment:
IIUC, this is not a perf critical path, @LuciferYang . In addition, the goal of this PR is not to avoid costs. Instead, it aims UX, `Avoid generating too many logs:`.
Anyway, you can suggest that in general for perf perspective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39876: [SPARK-42333][SQL] Change log level to debug when fetching result set from SparkExecuteStatementOperation
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #39876:
URL: https://github.com/apache/spark/pull/39876#issuecomment-1416216180
Merged to master/3.4. Thank you, @wangyum .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org