[GitHub] [superset] zhaoyongjie commented on pull request #22065: revert: feat: support None operand in EQUAL operator (#21713)"

[GitBox <gi...@apache.org>]

zhaoyongjie commented on PR #22065:
URL: https://github.com/apache/superset/pull/22065#issuecomment-1308122857

   @john-bodley I think the original PR intends to process the `None`(`None` in Python, `undefined` in JS) operand in the QueryObject instead of preparing to make changes in the UX. The major use case is ad-hoc filter in Native Filter, Cross Filter and Drill-to-detail.
   
   Before and after the original PR, the ad-hoc filter modal is not prepared to support `None` string or an empty string to generate a filter field in the QueryObject. When we want to generate `is null` snippet in `Equal to` or `In` operator in ad-hoc modal, the `<NULL>` operand is designed to do that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org