[GitHub] [solr] janhoy commented on a change in pull request #763: SOLR-15852: Smoketester fixes for maven artifact comparison

[GitBox <gi...@apache.org>]

janhoy commented on a change in pull request #763:
URL: https://github.com/apache/solr/pull/763#discussion_r836535286



##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -706,11 +707,7 @@ def is_port_in_use(port):
 def testSolrExample(unpackPath, javaPath, isSrc):
   # test solr using some examples it comes with
   logFile = '%s/solr-example.log' % unpackPath
-  if isSrc:
-    os.chdir(unpackPath+'/solr')
-    subprocess.call(['chmod','+x',unpackPath+'/solr/bin/solr', unpackPath+'/solr/bin/solr.cmd', unpackPath+'/solr/bin/solr.in.cmd'])

Review comment:
       Now that we run the test from `solr/packaging/build/dev` I think we're ok due to https://github.com/apache/solr/blob/main/solr/packaging/build.gradle#L140 ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org