You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/07/24 02:33:26 UTC

[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #1301: [CALCITE-3175] AssertionError during serializing RexLiteral with Enum type.

yanlin-Lynn commented on a change in pull request #1301: [CALCITE-3175] AssertionError during serializing RexLiteral with Enum type.
URL: https://github.com/apache/calcite/pull/1301#discussion_r306606140
 
 

 ##########
 File path: core/src/test/java/org/apache/calcite/plan/RelWriterTest.java
 ##########
 @@ -59,7 +63,7 @@
 /**
  * Unit test for {@link org.apache.calcite.rel.externalize.RelJson}.
  */
-public class RelWriterTest {
+public class RelWriterTest extends SqlToRelTestBase {
   public static final String XX = "{\n"
 
 Review comment:
   Make this class extend SqlToRelTestBase to reuse the created Tester instance. The constructor of TesterImpl is protected, cannot just create an instance of TesterImpl without extending SqlToRelTestBase.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services