You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/18 04:56:00 UTC
[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #1480: Popup when deleting an Upstream which is bound with Route
juzhiyuan opened a new issue #1480:
URL: https://github.com/apache/apisix-dashboard/issues/1480
# Bug report
## Describe the bug
1. Create a Route with an existing Upstream;
2. Delete that Upstream;
3. When editing that Route, because the upstream is deleted, then that Route Edit page is broken like the pictures above.
## Expected behavior
🤔 I know the Apache APISIX allows this action, but I would still prefer that once upstream is bound with a Route, then an error will popup when trying to delete the upstream. Or it's too strange to use in Dashboard.
cc @membphis @imjoey
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] github-actions[bot] commented on issue #1480: Popup when deleting an Upstream which is bound with Route
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #1480:
URL: https://github.com/apache/apisix-dashboard/issues/1480#issuecomment-954620689
This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1480: Popup when deleting an Upstream which is bound with Route
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1480:
URL: https://github.com/apache/apisix-dashboard/issues/1480#issuecomment-782621531
Allow users to force deletion.
When deleting an upstream object that is being used, it is better to remind users of risks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] github-actions[bot] closed issue #1480: Popup when deleting an Upstream which is bound with Route
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #1480:
URL: https://github.com/apache/apisix-dashboard/issues/1480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1480: Popup when deleting an Upstream which is bound with Route
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1480:
URL: https://github.com/apache/apisix-dashboard/issues/1480#issuecomment-782794338
> @nic-chen what do you think?
I think it’s good for us.
This avoids the inability to delete, and prevents users from deleting without their knowledge.
What about We add a `force` parameter. When this parameter is false or without this parameter, it cannot be deleted, and the backend returns a specific code, When `force` is true, it can be deleted ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] github-actions[bot] commented on issue #1480: Popup when deleting an Upstream which is bound with Route
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #1480:
URL: https://github.com/apache/apisix-dashboard/issues/1480#issuecomment-943208901
This issue has been marked as stale due to 30 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1480: Popup when deleting an Upstream which is bound with Route
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1480:
URL: https://github.com/apache/apisix-dashboard/issues/1480#issuecomment-782621570
@nic-chen what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1480: Popup when deleting an Upstream which is bound with Route
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1480:
URL: https://github.com/apache/apisix-dashboard/issues/1480#issuecomment-782816173
> What about We add a `force` parameter. When this parameter is false or without this parameter, it cannot be deleted, and the backend returns a specific code, When `force` is true, it can be deleted ?
agree +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org