[GitHub] [iceberg] nastra commented on pull request #5407: Core: Add RESTScanReporter to send scan report to REST endpoint

[GitBox <gi...@apache.org>]

nastra commented on PR #5407:
URL: https://github.com/apache/iceberg/pull/5407#issuecomment-1236717249

   > * Do we need a request object that adds another layer to the JSON? This is minor but it seems odd to have a record that just wraps another record to make the Java types work out (i.e. `ScanReportRequest` is a `RESTRequest`).
   
   Not sure if there's an easier way to do it, but essentially our `RESTClient` requires the body to be a `RESTRequest` and we can't make `ScanReport` (part of `iceberg-api`) just implement `RESTRequest` (part of `iceberg-core`) unfortunately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org