[GitHub] sjanc opened a new pull request #490: nimble/host: Refactor HCI commands sending functions

[gi...@git.apache.org]

sjanc opened a new pull request #490: nimble/host: Refactor HCI commands sending functions
URL: https://github.com/apache/mynewt-core/pull/490
 
 
   This refactors the way HCI commands are constructed and pass to
   controller. Instead of embedding opcode and len in command parameters
   buffer just pass it along with it. This has few adventages:
    - opcode OCF/OGF are contructed once on build time
    - buffer is always pass along with len
    - code is less confusing for static analysis tools (0 len buffer is
      always pass as NULL so no dangling pointers)
    - it is easier to follow (and debug)
   
   Nice bonus is ROM size reduction of net_nimble_host.a (54304->53710).
   
   This is also first step to making use of packed structures for HCI
   command instead of builders functions. This should reduce code size
   even further.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services